[MD History] Add grouped history toolbar.

[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ca7eb94a407ed57e2dfe1b1d8a5d446c7b72b093
Cr-Commit-Position: refs/heads/master@{#393788}

[calamity, 2016-05-11 01:22:21]

Description was changed from

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

UG=589357
==========

to

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

UG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-11 01:29:26]

Description was changed from

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

UG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-05-11 01:29:40]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-05-11 04:19:29]

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:108: text-transform:
uppercase;
Nit: Move this line down one for sorting reasons. (The CSS presubmit gets
confused sometimes)

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:120:
@apply(--layout-center);
Nit: @apply comes first, then --variable lines, then -webkit lines

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:129:
-webkit-margin-end: 24px;
Move this down, as above.

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:152: :host([is-rtl_])
.rtl-reversible {
psst,

here's a trick you won't find anywhere else because nowhere documents it
properly:

Replace :host([is-rtl_]) with :host-context([dir=rtl])

:host-context selects based on whether anything -above- the host matches the
selector [dir=rtl] (or something like that, anyway). It's used in a few places:
https://code.google.com/p/chromium/codesearch#search/&q=host-context%20file:c...

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/ui/webui/md_...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/ui/webui/md_...
chrome/browser/ui/webui/md_history_ui.cc:75: #if !defined(OS_ANDROID)
No need for the OS_ANDROID or the comment, since this is desktop-only.

[calamity, 2016-05-12 07:27:06]

I was gonna write tests but then I realized nothing is hooked up to anything
really. They'll come in the fat patch.

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:108: text-transform:
uppercase;
On 2016/05/11 04:19:29, tsergeant wrote:
> Nit: Move this line down one for sorting reasons. (The CSS presubmit gets
> confused sometimes)

Done.

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:120:
@apply(--layout-center);
On 2016/05/11 04:19:29, tsergeant wrote:
> Nit: @apply comes first, then --variable lines, then -webkit lines

Done.

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:129:
-webkit-margin-end: 24px;
On 2016/05/11 04:19:29, tsergeant wrote:
> Move this down, as above.

Done.

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:152: :host([is-rtl_])
.rtl-reversible {
On 2016/05/11 04:19:29, tsergeant wrote:
> psst,
> 
> here's a trick you won't find anywhere else because nowhere documents it
> properly:
> 
> Replace :host([is-rtl_]) with :host-context([dir=rtl])
> 
> :host-context selects based on whether anything -above- the host matches the
> selector [dir=rtl] (or something like that, anyway). It's used in a few
places:
>
https://code.google.com/p/chromium/codesearch#search/&q=host-context%20file:c...

Gnarly.

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/ui/webui/md_...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/ui/webui/md_...
chrome/browser/ui/webui/md_history_ui.cc:75: #if !defined(OS_ANDROID)
On 2016/05/11 04:19:29, tsergeant wrote:
> No need for the OS_ANDROID or the comment, since this is desktop-only.

Hmm. If we ever throw this onto android, I sure hope someone remembers to put
this back.

[Dan Beam, 2016-05-12 19:34:29]

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/1965913003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/history_toolbar.html:152: :host([is-rtl_])
.rtl-reversible {
On 2016/05/12 07:27:06, calamity wrote:
> On 2016/05/11 04:19:29, tsergeant wrote:
> > psst,
> > 
> > here's a trick you won't find anywhere else because nowhere documents it
> > properly:

http://robdodson.me/shadow-dom-css-cheat-sheet/#host-context

> > 
> > Replace :host([is-rtl_]) with :host-context([dir=rtl])
> > 
> > :host-context selects based on whether anything -above- the host matches the
> > selector [dir=rtl] (or something like that, anyway). It's used in a few
> places:
> >
>
https://code.google.com/p/chromium/codesearch#search/&q=host-context%20file:c...
> 
> Gnarly.

As propagator of this hack, I Thoroughly Endorse This Message(TM)

(let's just hope there's not a [dir=ltr] closer in the ancestry ;))

[tsergeant, 2016-05-13 02:50:09]

lgtm

[calamity, 2016-05-16 04:36:45]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-05-16 04:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1965913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1965913003/20001

[commit-bot: I haz the power, 2016-05-16 04:47:35]

Description was changed from

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-16 04:47:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-16 04:48:29]

Description was changed from

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add grouped history toolbar.

This CL implements the toolbar UI for grouped history.

BUG=589357
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ca7eb94a407ed57e2dfe1b1d8a5d446c7b72b093
Cr-Commit-Position: refs/heads/master@{#393788}
==========

[commit-bot: I haz the power, 2016-05-16 04:48:30]

Patchset 2 (id:??) landed as
https://crrev.com/ca7eb94a407ed57e2dfe1b1d8a5d446c7b72b093
Cr-Commit-Position: refs/heads/master@{#393788}