Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6273)

Unified Diff: chrome/test/data/webui/md_history/history_list_test.js

Issue 1974713002: [MD History] Unify query state in history-app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@secondary_toolbar
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_history/history_list_test.js
diff --git a/chrome/test/data/webui/md_history/history_list_test.js b/chrome/test/data/webui/md_history/history_list_test.js
index 8b35227f1f326ec608caa7584d8cafcdf5a49f46..53eac5dc5a382aa73d5e256a85e0c2b85139d6d8 100644
--- a/chrome/test/data/webui/md_history/history_list_test.js
+++ b/chrome/test/data/webui/md_history/history_list_test.js
@@ -30,7 +30,7 @@ cr.define('md_history.history_list_test', function() {
});
test('cancelling selection of multiple items', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
flush(function() {
var items = Polymer.dom(element.root)
.querySelectorAll('history-item');
@@ -62,7 +62,7 @@ cr.define('md_history.history_list_test', function() {
});
test('setting first and last items', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
flush(function() {
var items =
@@ -80,8 +80,8 @@ cr.define('md_history.history_list_test', function() {
});
test('updating history results', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
- element.addNewResults(ADDITIONAL_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
+ element.addNewResults(ADDITIONAL_RESULTS);
flush(function() {
var items =
@@ -100,8 +100,8 @@ cr.define('md_history.history_list_test', function() {
});
test('deleting multiple items from view', function(done) {
- element.addNewResults(TEST_HISTORY_RESULTS, '');
- element.addNewResults(ADDITIONAL_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
+ element.addNewResults(ADDITIONAL_RESULTS);
flush(function() {
items = Polymer.dom(element.root).querySelectorAll('history-item');
@@ -134,8 +134,8 @@ cr.define('md_history.history_list_test', function() {
test('search results display with correct item title', function(done) {
element.addNewResults(
- [createHistoryEntry('2016-03-15', 'https://www.google.com')],
- 'Google');
+ [createHistoryEntry('2016-03-15', 'https://www.google.com')]);
+ element.searchedTerm = 'Google';
flush(function() {
var item = element.$$('history-item');
@@ -154,13 +154,13 @@ cr.define('md_history.history_list_test', function() {
});
test('correct display message when no history available', function(done) {
- element.addNewResults([], '');
+ element.addNewResults([]);
flush(function() {
assertFalse(element.$['no-results'].hidden);
assertTrue(element.$['infinite-list'].hidden);
- element.addNewResults(TEST_HISTORY_RESULTS, '');
+ element.addNewResults(TEST_HISTORY_RESULTS);
flush(function() {
assertTrue(element.$['no-results'].hidden);
@@ -172,6 +172,7 @@ cr.define('md_history.history_list_test', function() {
teardown(function() {
element.historyData = [];
+ element.searchedTerm = '';
registerMessageCallback('removeVisits', this, undefined);
});
});

Powered by Google App Engine
This is Rietveld 408576698