Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 16998003: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, tzik+watch_chromium.org, rginda+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ben+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, dbeam+watch-options_chromium.org, derat+watch_chromium.org, tbarzic+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, cc-bugs_chromium.org, James Su, davemoore+watch_chromium.org
Visibility:
Public.

Description

Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*" BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206357

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+870 lines, -766 lines) Patch
M ash/desktop_background/desktop_background_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/prefs/testing_pref_service.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/raster_worker_pool.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/contacts/gdata_contacts_service_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dbus/cros_dbus_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/service_provider_test_helper.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 15 chunks +48 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 3 chunks +43 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation.cc View 2 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/update_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/local_file_reader.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 11 chunks +18 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_manifest_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_verifier.cc View 4 chunks +19 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 25 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 11 chunks +63 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/screensaver/screensaver_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/web_socket_proxy.cc View 9 chunks +19 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/apps_model_builder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/history_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/gsm_sms_client_unittest.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M chromeos/dbus/ibus/ibus_client_unittest.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chromeos/dbus/ibus/ibus_config_client_unittest.cc View 15 chunks +53 lines, -57 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc View 1 chunk +11 lines, -12 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service_unittest.cc View 8 chunks +94 lines, -90 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 9 chunks +53 lines, -40 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service_unittest.cc View 5 chunks +78 lines, -69 lines 0 comments Download
M chromeos/dbus/modem_messaging_client_unittest.cc View 3 chunks +12 lines, -10 lines 0 comments Download
M chromeos/dbus/shill_client_unittest_base.cc View 1 chunk +14 lines, -15 lines 0 comments Download
M chromeos/dbus/shill_device_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/shill_manager_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_profile_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 8 chunks +12 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 13 chunks +18 lines, -20 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos_unittest.cc View 10 chunks +19 lines, -15 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/syncable/canned_syncable_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-13 22:58:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16998003/5001
7 years, 6 months ago (2013-06-13 23:03:11 UTC) #2
commit-bot: I haz the power
7 years, 6 months ago (2013-06-14 07:30:41 UTC) #3
Message was sent while issue was closed.
Change committed as 206357

Powered by Google App Engine
This is Rietveld 408576698