Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/chromeos/dbus/cros_dbus_service_unittest.cc

Issue 16998003: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/dbus/cros_dbus_service.h" 5 #include "chrome/browser/chromeos/dbus/cros_dbus_service.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "dbus/message.h" 10 #include "dbus/message.h"
(...skipping 24 matching lines...) Expand all
35 } 35 }
36 36
37 // Creates an instance of CrosDBusService with mocks injected. 37 // Creates an instance of CrosDBusService with mocks injected.
38 virtual void SetUp() { 38 virtual void SetUp() {
39 // Create a mock bus. 39 // Create a mock bus.
40 dbus::Bus::Options options; 40 dbus::Bus::Options options;
41 options.bus_type = dbus::Bus::SYSTEM; 41 options.bus_type = dbus::Bus::SYSTEM;
42 mock_bus_ = new dbus::MockBus(options); 42 mock_bus_ = new dbus::MockBus(options);
43 43
44 // ShutdownAndBlock() will be called in TearDown(). 44 // ShutdownAndBlock() will be called in TearDown().
45 EXPECT_CALL(*mock_bus_, ShutdownAndBlock()).WillOnce(Return()); 45 EXPECT_CALL(*mock_bus_.get(), ShutdownAndBlock()).WillOnce(Return());
46 46
47 // Create a mock exported object that behaves as 47 // Create a mock exported object that behaves as
48 // org.chromium.CrosDBusService. 48 // org.chromium.CrosDBusService.
49 mock_exported_object_ = 49 mock_exported_object_ =
50 new dbus::MockExportedObject(mock_bus_.get(), 50 new dbus::MockExportedObject(mock_bus_.get(),
51 dbus::ObjectPath(kLibCrosServicePath)); 51 dbus::ObjectPath(kLibCrosServicePath));
52 52
53 // |mock_bus_|'s GetExportedObject() will return mock_exported_object_| 53 // |mock_bus_|'s GetExportedObject() will return mock_exported_object_|
54 // for the given service name and the object path. 54 // for the given service name and the object path.
55 EXPECT_CALL(*mock_bus_, GetExportedObject( 55 EXPECT_CALL(*mock_bus_.get(),
56 dbus::ObjectPath(kLibCrosServicePath))) 56 GetExportedObject(dbus::ObjectPath(kLibCrosServicePath)))
57 .WillOnce(Return(mock_exported_object_.get())); 57 .WillOnce(Return(mock_exported_object_.get()));
58 58
59 // Create a mock proxy resolution service. 59 // Create a mock proxy resolution service.
60 MockProxyResolutionService* mock_proxy_resolution_service_provider = 60 MockProxyResolutionService* mock_proxy_resolution_service_provider =
61 new MockProxyResolutionService; 61 new MockProxyResolutionService;
62 62
63 // Start() will be called with |mock_exported_object_|. 63 // Start() will be called with |mock_exported_object_|.
64 EXPECT_CALL(*mock_proxy_resolution_service_provider, 64 EXPECT_CALL(*mock_proxy_resolution_service_provider,
65 Start(Eq(mock_exported_object_))).WillOnce(Return()); 65 Start(Eq(mock_exported_object_))).WillOnce(Return());
66 // Initialize the cros service with the mocks injected. 66 // Initialize the cros service with the mocks injected.
67 CrosDBusService::InitializeForTesting( 67 CrosDBusService::InitializeForTesting(
68 mock_bus_, mock_proxy_resolution_service_provider); 68 mock_bus_.get(), mock_proxy_resolution_service_provider);
69 } 69 }
70 70
71 virtual void TearDown() { 71 virtual void TearDown() {
72 // Shutdown the cros service. 72 // Shutdown the cros service.
73 CrosDBusService::Shutdown(); 73 CrosDBusService::Shutdown();
74 74
75 // Shutdown the bus. 75 // Shutdown the bus.
76 mock_bus_->ShutdownAndBlock(); 76 mock_bus_->ShutdownAndBlock();
77 } 77 }
78 78
79 protected: 79 protected:
80 scoped_refptr<dbus::MockBus> mock_bus_; 80 scoped_refptr<dbus::MockBus> mock_bus_;
81 scoped_refptr<dbus::MockExportedObject> mock_exported_object_; 81 scoped_refptr<dbus::MockExportedObject> mock_exported_object_;
82 }; 82 };
83 83
84 TEST_F(CrosDBusServiceTest, Start) { 84 TEST_F(CrosDBusServiceTest, Start) {
85 // Simply start the service and see if mock expectations are met: 85 // Simply start the service and see if mock expectations are met:
86 // - The service object is exported by GetExportedObject() 86 // - The service object is exported by GetExportedObject()
87 // - The proxy resolution service is started. 87 // - The proxy resolution service is started.
88 } 88 }
89 89
90 } // namespace chromeos 90 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698