Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/file_manager_manifest_unittest.cc

Issue 16998003: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_number_conversions.h" 5 #include "base/strings/string_number_conversions.h"
6 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handler.h " 6 #include "chrome/browser/chromeos/extensions/file_manager/file_browser_handler.h "
7 #include "chrome/common/extensions/extension_builder.h" 7 #include "chrome/common/extensions/extension_builder.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 9 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
10 #include "chrome/common/extensions/value_builder.h" 10 #include "chrome/common/extensions/value_builder.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 .Append(DictionaryBuilder() 68 .Append(DictionaryBuilder()
69 .Set("id", "ExtremelyCoolAction") 69 .Set("id", "ExtremelyCoolAction")
70 .Set("default_title", "Be Amazed") 70 .Set("default_title", "Be Amazed")
71 .Set("default_icon", "icon.png") 71 .Set("default_icon", "icon.png")
72 .Set("file_filters", ListBuilder() 72 .Set("file_filters", ListBuilder()
73 .Append("filesystem:*.txt"))))) 73 .Append("filesystem:*.txt")))))
74 .Build(); 74 .Build();
75 75
76 ASSERT_TRUE(extension.get()); 76 ASSERT_TRUE(extension.get());
77 FileBrowserHandler::List* handlers = 77 FileBrowserHandler::List* handlers =
78 FileBrowserHandler::GetHandlers(extension); 78 FileBrowserHandler::GetHandlers(extension.get());
79 ASSERT_TRUE(handlers != NULL); 79 ASSERT_TRUE(handlers != NULL);
80 ASSERT_EQ(handlers->size(), 1U); 80 ASSERT_EQ(handlers->size(), 1U);
81 const FileBrowserHandler* action = handlers->at(0).get(); 81 const FileBrowserHandler* action = handlers->at(0).get();
82 82
83 EXPECT_EQ(action->id(), "ExtremelyCoolAction"); 83 EXPECT_EQ(action->id(), "ExtremelyCoolAction");
84 EXPECT_EQ(action->title(), "Be Amazed"); 84 EXPECT_EQ(action->title(), "Be Amazed");
85 EXPECT_EQ(action->icon_path(), "icon.png"); 85 EXPECT_EQ(action->icon_path(), "icon.png");
86 const extensions::URLPatternSet& patterns = action->file_url_patterns(); 86 const extensions::URLPatternSet& patterns = action->file_url_patterns();
87 ASSERT_EQ(patterns.patterns().size(), 1U); 87 ASSERT_EQ(patterns.patterns().size(), 1U);
88 EXPECT_TRUE(action->MatchesURL( 88 EXPECT_TRUE(action->MatchesURL(
(...skipping 15 matching lines...) Expand all
104 .Append(DictionaryBuilder() 104 .Append(DictionaryBuilder()
105 .Set("id", "ID") 105 .Set("id", "ID")
106 .Set("default_title", "Default title") 106 .Set("default_title", "Default title")
107 .Set("default_icon", "icon.png") 107 .Set("default_icon", "icon.png")
108 .Set("file_filters", ListBuilder() 108 .Set("file_filters", ListBuilder()
109 .Append("filesystem:*.txt"))))) 109 .Append("filesystem:*.txt")))))
110 .Build(); 110 .Build();
111 111
112 ASSERT_TRUE(extension.get()); 112 ASSERT_TRUE(extension.get());
113 FileBrowserHandler::List* handlers = 113 FileBrowserHandler::List* handlers =
114 FileBrowserHandler::GetHandlers(extension); 114 FileBrowserHandler::GetHandlers(extension.get());
115 ASSERT_TRUE(handlers != NULL); 115 ASSERT_TRUE(handlers != NULL);
116 ASSERT_EQ(handlers->size(), 1U); 116 ASSERT_EQ(handlers->size(), 1U);
117 const FileBrowserHandler* action = handlers->at(0).get(); 117 const FileBrowserHandler* action = handlers->at(0).get();
118 118
119 const extensions::URLPatternSet& patterns = action->file_url_patterns(); 119 const extensions::URLPatternSet& patterns = action->file_url_patterns();
120 ASSERT_EQ(patterns.patterns().size(), 1U); 120 ASSERT_EQ(patterns.patterns().size(), 1U);
121 EXPECT_TRUE(action->MatchesURL( 121 EXPECT_TRUE(action->MatchesURL(
122 GURL("filesystem:chrome-extension://foo/local/test.txt"))); 122 GURL("filesystem:chrome-extension://foo/local/test.txt")));
123 } 123 }
124 124
(...skipping 10 matching lines...) Expand all
135 .Set("default_title", "Default title") 135 .Set("default_title", "Default title")
136 .Set("default_icon", "icon.png") 136 .Set("default_icon", "icon.png")
137 .Set("file_filters", ListBuilder() 137 .Set("file_filters", ListBuilder()
138 .Append("filesystem:*.txt")) 138 .Append("filesystem:*.txt"))
139 .Set("file_access", ListBuilder() 139 .Set("file_access", ListBuilder()
140 .Append("create"))))) 140 .Append("create")))))
141 .Build(); 141 .Build();
142 142
143 ASSERT_TRUE(extension.get()); 143 ASSERT_TRUE(extension.get());
144 FileBrowserHandler::List* handlers = 144 FileBrowserHandler::List* handlers =
145 FileBrowserHandler::GetHandlers(extension); 145 FileBrowserHandler::GetHandlers(extension.get());
146 ASSERT_TRUE(handlers != NULL); 146 ASSERT_TRUE(handlers != NULL);
147 ASSERT_EQ(handlers->size(), 1U); 147 ASSERT_EQ(handlers->size(), 1U);
148 const FileBrowserHandler* action = handlers->at(0).get(); 148 const FileBrowserHandler* action = handlers->at(0).get();
149 const extensions::URLPatternSet& patterns = action->file_url_patterns(); 149 const extensions::URLPatternSet& patterns = action->file_url_patterns();
150 150
151 EXPECT_EQ(patterns.patterns().size(), 0U); 151 EXPECT_EQ(patterns.patterns().size(), 0U);
152 EXPECT_TRUE(action->HasCreateAccessPermission()); 152 EXPECT_TRUE(action->HasCreateAccessPermission());
153 EXPECT_FALSE(action->CanRead()); 153 EXPECT_FALSE(action->CanRead());
154 EXPECT_FALSE(action->CanWrite()); 154 EXPECT_FALSE(action->CanWrite());
155 } 155 }
(...skipping 17 matching lines...) Expand all
173 LoadExtension(Manifest(manifest_value.get(), "override_files"), 173 LoadExtension(Manifest(manifest_value.get(), "override_files"),
174 &error, extensions::Manifest::COMPONENT, Extension::NO_FLAGS); 174 &error, extensions::Manifest::COMPONENT, Extension::NO_FLAGS);
175 #if defined(FILE_MANAGER_EXTENSION) 175 #if defined(FILE_MANAGER_EXTENSION)
176 EXPECT_EQ("", error); 176 EXPECT_EQ("", error);
177 #else 177 #else
178 EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error); 178 EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error);
179 #endif 179 #endif
180 } 180 }
181 181
182 } // namespace 182 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698