chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc - Issue 16998003: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc

Issue 16998003: Update CrOS to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/dbus/cros_dbus_service_unittest.cc ('k') | chrome/browser/chromeos/dbus/service_provider_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc

diff --git a/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc b/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc

index c72d30d438d6b053d696358e03806539434caf95..d2eb77ab97385e480cdff29f714ae2489e526a58 100644

--- a/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc

+++ b/chrome/browser/chromeos/dbus/proxy_resolution_service_provider.cc

@@ -116,7 +116,7 @@ class ProxyResolverImpl : public ProxyResolverInterface {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

// Check if we have the URLRequestContextGetter.

- if (!getter) {

+ if (!getter.get()) {

request->error_ = "No URLRequestContextGetter";

request->OnCompletion(net::ERR_UNEXPECTED);

return;