Issue 16934003: Inspector: replace generic discardAgents logic with explicit call to discard a listener.

Issue 16934003: Inspector: replace generic discardAgents logic with explicit call to discard a listener. (Closed)

Created:
7 years, 6 months ago by Vladislav Kaznacheev

Modified:
7 years, 5 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Inspector: replace generic discardAgents logic with explicit call to discard a listener. This relaxes the requirements on the order of agents creation/deletion BUG=248092

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -25 lines)			Patch
M	Source/core/inspector/InspectorBaseAgent.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorBaseAgent.cpp	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/inspector/InspectorController.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDOMAgent.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMAgent.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMDebuggerAgent.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDOMDebuggerAgent.cpp	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/16934003/diff/1/Source/core/inspector/InspectorDOMAgent.h File Source/core/inspector/InspectorDOMAgent.h (right): https://chromiumcodereview.appspot.com/16934003/diff/1/Source/core/inspector/InspectorDOMAgent.h#newcode104 Source/core/inspector/InspectorDOMAgent.h:104: virtual void discardListener() = 0; willDestroyDOMAgent https://chromiumcodereview.appspot.com/16934003/diff/1/Source/core/inspector/InspectorDebuggerAgent.h File ...

7 years, 6 months ago (2013-06-14 06:30:24 UTC) #2

pfeldman

7 years, 6 months ago (2013-06-14 06:41:18 UTC) #3

I don't like ad hoc listeners. It makes code even more confusing. We don't need
multiple connection support at such cost. If domains depend on each other
(CSS->DOM), let it be explicit. Why not ref count them?

Expand Messages | Collapse Messages