Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 16934003: Inspector: replace generic discardAgents logic with explicit call to discard a listener. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 void willFireTimer(ScriptExecutionContext*, int timerId); 86 void willFireTimer(ScriptExecutionContext*, int timerId);
87 void didRequestAnimationFrame(Document*, int callbackId); 87 void didRequestAnimationFrame(Document*, int callbackId);
88 void didCancelAnimationFrame(Document*, int callbackId); 88 void didCancelAnimationFrame(Document*, int callbackId);
89 void willFireAnimationFrame(Document*, int callbackId); 89 void willFireAnimationFrame(Document*, int callbackId);
90 void willHandleEvent(Event*); 90 void willHandleEvent(Event*);
91 void didFireWebGLError(Document*, const String& eventName, const String& con soleMessage); 91 void didFireWebGLError(Document*, const String& eventName, const String& con soleMessage);
92 92
93 void didProcessTask(); 93 void didProcessTask();
94 94
95 virtual void clearFrontend(); 95 virtual void clearFrontend();
96 virtual void discardAgent();
97 96
98 private: 97 private:
99 InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorCompositeState*, In spectorDOMAgent*, InspectorDebuggerAgent*); 98 InspectorDOMDebuggerAgent(InstrumentingAgents*, InspectorCompositeState*, In spectorDOMAgent*, InspectorDebuggerAgent*);
100 99
101 void pauseOnNativeEventIfNeeded(bool isDOMEvent, const String& eventName, bo ol synchronous); 100 void pauseOnNativeEventIfNeeded(bool isDOMEvent, const String& eventName, bo ol synchronous);
102 101
103 // InspectorDebuggerAgent::Listener implementation. 102 // InspectorDebuggerAgent::Listener implementation.
104 virtual void debuggerWasEnabled(); 103 virtual void debuggerWasEnabled();
105 virtual void debuggerWasDisabled(); 104 virtual void debuggerWasDisabled();
106 virtual void stepInto(); 105 virtual void stepInto();
107 virtual void didPause(); 106 virtual void didPause();
107 virtual void willDestroyDebuggerAgent();
108
108 void disable(); 109 void disable();
109 110
110 void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion , InspectorObject* description); 111 void descriptionForDOMEvent(Node* target, int breakpointType, bool insertion , InspectorObject* description);
111 void updateSubtreeBreakpoints(Node*, uint32_t rootMask, bool set); 112 void updateSubtreeBreakpoints(Node*, uint32_t rootMask, bool set);
112 bool hasBreakpoint(Node*, int type); 113 bool hasBreakpoint(Node*, int type);
113 void discardBindings(); 114 void discardBindings();
114 void setBreakpoint(ErrorString*, const String& eventName); 115 void setBreakpoint(ErrorString*, const String& eventName);
115 void removeBreakpoint(ErrorString*, const String& eventName); 116 void removeBreakpoint(ErrorString*, const String& eventName);
116 117
117 void clear(); 118 void clear();
118 119
119 InspectorDOMAgent* m_domAgent; 120 InspectorDOMAgent* m_domAgent;
120 InspectorDebuggerAgent* m_debuggerAgent; 121 InspectorDebuggerAgent* m_debuggerAgent;
121 HashMap<Node*, uint32_t> m_domBreakpoints; 122 HashMap<Node*, uint32_t> m_domBreakpoints;
122 bool m_pauseInNextEventListener; 123 bool m_pauseInNextEventListener;
123 }; 124 };
124 125
125 } // namespace WebCore 126 } // namespace WebCore
126 127
127 128
128 #endif // !defined(InspectorDOMDebuggerAgent_h) 129 #endif // !defined(InspectorDOMDebuggerAgent_h)
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698