Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 16934003: Inspector: replace generic discardAgents logic with explicit call to discard a listener. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 3 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 , m_javaScriptPauseScheduled(false) 77 , m_javaScriptPauseScheduled(false)
78 , m_listener(0) 78 , m_listener(0)
79 { 79 {
80 // FIXME: make breakReason optional so that there was no need to init it wit h "other". 80 // FIXME: make breakReason optional so that there was no need to init it wit h "other".
81 clearBreakDetails(); 81 clearBreakDetails();
82 m_state->setLong(DebuggerAgentState::pauseOnExceptionsState, ScriptDebugServ er::DontPauseOnExceptions); 82 m_state->setLong(DebuggerAgentState::pauseOnExceptionsState, ScriptDebugServ er::DontPauseOnExceptions);
83 } 83 }
84 84
85 InspectorDebuggerAgent::~InspectorDebuggerAgent() 85 InspectorDebuggerAgent::~InspectorDebuggerAgent()
86 { 86 {
87 if (m_listener)
88 m_listener->willDestroyDebuggerAgent();
87 ASSERT(!m_instrumentingAgents->inspectorDebuggerAgent()); 89 ASSERT(!m_instrumentingAgents->inspectorDebuggerAgent());
88 } 90 }
89 91
90 void InspectorDebuggerAgent::enable() 92 void InspectorDebuggerAgent::enable()
91 { 93 {
92 m_instrumentingAgents->setInspectorDebuggerAgent(this); 94 m_instrumentingAgents->setInspectorDebuggerAgent(this);
93 95
94 // FIXME(WK44513): breakpoints activated flag should be synchronized between all front-ends 96 // FIXME(WK44513): breakpoints activated flag should be synchronized between all front-ends
95 scriptDebugServer().setBreakpointsActivated(true); 97 scriptDebugServer().setBreakpointsActivated(true);
96 startListeningScriptDebugServer(); 98 startListeningScriptDebugServer();
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
843 void InspectorDebuggerAgent::reset() 845 void InspectorDebuggerAgent::reset()
844 { 846 {
845 m_scripts.clear(); 847 m_scripts.clear();
846 m_breakpointIdToDebugServerBreakpointIds.clear(); 848 m_breakpointIdToDebugServerBreakpointIds.clear();
847 if (m_frontend) 849 if (m_frontend)
848 m_frontend->globalObjectCleared(); 850 m_frontend->globalObjectCleared();
849 } 851 }
850 852
851 } // namespace WebCore 853 } // namespace WebCore
852 854
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698