Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16833003: cc: Emulate BeginFrame in OutputSurfaces that don't support it natively (Closed)

Created:
7 years, 6 months ago by brianderson
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, chrome-speed-team+watch_google.com, nona+watch_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, James Su, boliu, joth
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: Emulate BeginFrame in OutputSurfaces that don't support it natively This includes two small fixes for the original version of this patch that broke software compositing and WebView. This will allow us to avoid having two different code paths in the Scheduler. It also allows us to more easily remove the VSyncTimeSource and FrameRateController from the Scheduler. This patch instantiates the FrameRateController inside of OutputSurface for now, but the FrameRateController could be removed in future patches. BUG=245920 BUG=243497 TBR=nduca@chromium.org,sievers@chromium.org,kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+720 lines, -825 lines) Patch
M cc/cc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/output_surface.h View 7 chunks +38 lines, -6 lines 0 comments Download
M cc/output/output_surface.cc View 6 chunks +127 lines, -23 lines 0 comments Download
M cc/output/output_surface_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 9 chunks +147 lines, -12 lines 0 comments Download
M cc/scheduler/frame_rate_controller.h View 5 chunks +13 lines, -8 lines 0 comments Download
M cc/scheduler/frame_rate_controller.cc View 6 chunks +16 lines, -10 lines 0 comments Download
M cc/scheduler/frame_rate_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.h View 5 chunks +14 lines, -18 lines 0 comments Download
M cc/scheduler/scheduler.cc View 6 chunks +68 lines, -57 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 5 chunks +6 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 7 chunks +15 lines, -0 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 18 chunks +113 lines, -170 lines 0 comments Download
D cc/scheduler/vsync_time_source.h View 1 chunk +0 lines, -78 lines 0 comments Download
D cc/scheduler/vsync_time_source.cc View 1 chunk +0 lines, -76 lines 0 comments Download
cc/scheduler/vsync_time_source_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/fake_output_surface.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/test/fake_output_surface.cc View 6 chunks +21 lines, -5 lines 0 comments Download
M cc/test/layer_tree_test.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M cc/test/scheduler_test_common.h View 1 chunk +0 lines, -30 lines 0 comments Download
M cc/test/scheduler_test_common.cc View 1 chunk +0 lines, -10 lines 0 comments Download
cc/trees/layer_tree_host_impl.h View 3 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +19 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +4 lines, -58 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/proxy.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.h View 10 chunks +12 lines, -29 lines 0 comments Download
M cc/trees/thread_proxy.cc View 9 chunks +51 lines, -58 lines 0 comments Download
M chrome/test/perf/rendering/latency_tests.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/16833003/1
7 years, 6 months ago (2013-06-12 19:21:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/16833003/1
7 years, 6 months ago (2013-06-13 03:12:04 UTC) #2
commit-bot: I haz the power
7 years, 6 months ago (2013-06-13 06:59:23 UTC) #3
Message was sent while issue was closed. 
Change committed as 206020

Powered by Google App Engine
This is Rietveld 408576698