Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1682083004: Add additive animation support for CSS property transform-origin (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_radiusInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additive animation support for CSS property transform-origin This patch adds support for composite modes on transform-origin CSS animations via element.animate(). BUG=437696 Committed: https://crrev.com/346c0dabb01a57e3f83c38101fed5ef922f183ca Cr-Commit-Position: refs/heads/master@{#377877}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/animations/composition/transform-origin-composition.html View 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 1 5 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-11 04:59:18 UTC) #2
Eric Willigers
lgtm https://codereview.chromium.org/1682083004/diff/1/third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h File third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h (right): https://codereview.chromium.org/1682083004/diff/1/third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h#newcode20 third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h:20: { } ASSERT(property == CSSPropertyTransformOrigin);
4 years, 10 months ago (2016-02-11 06:13:40 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1682083004/diff/1/third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h File third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h (right): https://codereview.chromium.org/1682083004/diff/1/third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h#newcode20 third_party/WebKit/Source/core/animation/CSSTransformOriginInterpolationType.h:20: { } On 2016/02/11 at 06:13:39, Eric Willigers wrote: ...
4 years, 10 months ago (2016-02-11 06:16:38 UTC) #4
alancutter (OOO until 2018)
+dstockwell for core.gypi changes.
4 years, 10 months ago (2016-02-17 05:46:55 UTC) #6
dstockwell
lgtm
4 years, 10 months ago (2016-02-18 03:00:16 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682083004/20001
4 years, 10 months ago (2016-02-25 03:32:59 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-25 06:29:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1682083004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1682083004/20001
4 years, 10 months ago (2016-02-26 12:25:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 13:47:34 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 13:49:03 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/346c0dabb01a57e3f83c38101fed5ef922f183ca
Cr-Commit-Position: refs/heads/master@{#377877}

Powered by Google App Engine
This is Rietveld 408576698