Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1644883002: Add additive animation support for CSS property translate (Closed)

Created:
4 years, 11 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_propertyInterpolationTypesMapping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additive animation support for CSS property translate This patch adds support for composite modes on translate CSS animations via element.animate(). BUG=437696 Committed: https://crrev.com/8a3777d77af8e154f4eb03bfa87a8c73b58fa880 Cr-Commit-Position: refs/heads/master@{#377830}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review changes #

Patch Set 3 : Rebased #

Messages

Total messages: 22 (9 generated)
alancutter (OOO until 2018)
+leviw for trivial change to Length.h.
4 years, 11 months ago (2016-01-28 04:03:45 UTC) #2
leviw_travelin_and_unemployed
Length change lgtm.
4 years, 10 months ago (2016-01-29 00:07:06 UTC) #3
alancutter (OOO until 2018)
+ericwilligers for core/animation changes.
4 years, 10 months ago (2016-02-17 05:57:13 UTC) #5
Eric Willigers
https://codereview.chromium.org/1644883002/diff/1/third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html File third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html (right): https://codereview.chromium.org/1644883002/diff/1/third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html#newcode20 third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html:20: }, { Perhaps add a test with inherited: '200px ...
4 years, 10 months ago (2016-02-17 07:15:50 UTC) #6
alancutter (OOO until 2018)
https://codereview.chromium.org/1644883002/diff/1/third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html File third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html (right): https://codereview.chromium.org/1644883002/diff/1/third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html#newcode20 third_party/WebKit/LayoutTests/animations/responsive/translate-responsive.html:20: }, { On 2016/02/17 at 07:15:50, Eric Willigers wrote: ...
4 years, 10 months ago (2016-02-17 23:50:22 UTC) #8
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-18 00:50:35 UTC) #9
alancutter (OOO until 2018)
+dstockwell for core.gypi changes.
4 years, 10 months ago (2016-02-18 03:56:28 UTC) #11
dstockwell
lgtm
4 years, 10 months ago (2016-02-18 07:25:37 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644883002/40001
4 years, 10 months ago (2016-02-25 03:29:44 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/179338)
4 years, 10 months ago (2016-02-25 06:57:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1644883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1644883002/40001
4 years, 10 months ago (2016-02-26 02:17:40 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-26 06:20:23 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 06:21:41 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a3777d77af8e154f4eb03bfa87a8c73b58fa880
Cr-Commit-Position: refs/heads/master@{#377830}

Powered by Google App Engine
This is Rietveld 408576698