Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1689383002: Add additive animation support for CSS property background-size (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_transformOriginInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add additive animation support for CSS property background-size This patch adds support for composite modes on background-size CSS animations via element.animate(). This change also makes interpolation between background-size and -webkit-mask-size fall back to 50% flip behaviour if a keyword is used to bring us inline with spec text: https://drafts.csswg.org/css-backgrounds-3/#the-background-size BUG=437696 Committed: https://crrev.com/332293fdcd6ebf1b489304e5d52903ddb2eaf5ea Cr-Commit-Position: refs/heads/master@{#378104}

Patch Set 1 #

Patch Set 2 : core.gypi #

Total comments: 4

Patch Set 3 : Review changes #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -147 lines) Patch
A third_party/WebKit/LayoutTests/animations/composition/background-size-composition.html View 1 chunk +86 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/webkit-mask-size-interpolation.html View 3 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/webkit-mask-size-interpolation-expected.txt View 2 chunks +56 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 1 2 3 4 chunks +14 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.h View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 1 2 3 7 chunks +132 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/FillLayer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (9 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-12 03:07:20 UTC) #2
Eric Willigers
https://codereview.chromium.org/1689383002/diff/20001/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp File third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp (left): https://codereview.chromium.org/1689383002/diff/20001/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp#oldcode77 third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp:77: if (!state.parentStyle()) Why isn't this needed anymore? https://codereview.chromium.org/1689383002/diff/20001/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp File ...
4 years, 10 months ago (2016-02-16 06:57:01 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1689383002/diff/20001/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp File third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp (left): https://codereview.chromium.org/1689383002/diff/20001/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp#oldcode77 third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp:77: if (!state.parentStyle()) On 2016/02/16 at 06:57:01, Eric Willigers wrote: ...
4 years, 10 months ago (2016-02-17 06:47:12 UTC) #4
Eric Willigers
lgtm
4 years, 10 months ago (2016-02-17 10:49:04 UTC) #5
alancutter (OOO until 2018)
+dstockwell for core.gypi and core/style changes.
4 years, 10 months ago (2016-02-17 23:25:47 UTC) #7
dstockwell
lgtm
4 years, 10 months ago (2016-02-18 02:59:00 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689383002/60001
4 years, 10 months ago (2016-02-25 03:42:50 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/179294)
4 years, 10 months ago (2016-02-25 05:02:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689383002/60001
4 years, 10 months ago (2016-02-26 18:21:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/29872)
4 years, 10 months ago (2016-02-26 21:37:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1689383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1689383002/60001
4 years, 10 months ago (2016-02-27 00:02:59 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-27 03:31:14 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 03:32:35 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/332293fdcd6ebf1b489304e5d52903ddb2eaf5ea
Cr-Commit-Position: refs/heads/master@{#378104}

Powered by Google App Engine
This is Rietveld 408576698