Chromium Code Reviews Chromium Code Reviews
Issue
16756004:
Revert 205059 "We were seeing ActivityLog memory leaks and assor..." (Closed)
DescriptionRevert 205059 "We were seeing ActivityLog memory leaks and assor..."
> We were seeing ActivityLog memory leaks and assorted other errors. It was due to poor handling of error conditions (not cleaning up the DB state if something goes wrong). This CL should fix that.
>
> Added every error-handling measure I could think of:
>
> 1. Moves the error handling into the ActivityDatabase class so that we can immediately (synchronously) kill the database, instead of asynchronously doing it from the ActivityLog
> 2. Closes the db even for non-catastrophic errors, so that we aren't just hammering away when the I/O thread has gone wonky
> 3. Adds checks in ActivityDatabase to see if the db is valid so that we aren't constantly continuing to try to write to a closed database
> 4. Removes dead code that I had superstitiously added to the activity_log_unittest to see if adding it would remove the memory leaks (it didn't)
> 5. Failures in Init explicitly call the error handling code, in case it isn't automatically triggered
> 6. Record now returns a bool, so we can stop trying to record actions if one has failed
> 7. In the case of unittests where everything is running on one thread anyway, ActivityLog synchronously kills the Activity Database
> 8. ActivityLog does cleanup on Shutdown, which happens before references start dying
>
> BUG=246825
>
> Review URL: https://chromiumcodereview.appspot.com/16510002
TBR=felt@chromium.org
Patch Set 1 #Messages
Total messages: 6 (0 generated)
|
