Revert 205059 "We were seeing ActivityLog memory leaks and assor..."

trunk/src/chrome/browser/extensions/activity_log/activity_actions.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_
 
 #include <string>
 #include "base/memory/ref_counted_memory.h"
 #include "base/time.h"
 #include "base/values.h"
 #include "chrome/common/extensions/api/activity_log_private.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "sql/transaction.h"
 
 namespace extensions {
 
 // This is the interface for extension actions that are to be recorded in
 // the activity log.
 class Action : public base::RefCountedThreadSafe<Action> {
  public:
   static const char* kTableBasicFields;
 
   // Initialize the table for a given action type.
   static bool InitializeTableInternal(sql::Connection* db);
 
   // Record the action in the database.
-  virtual bool Record(sql::Connection* db) = 0;
+  virtual void Record(sql::Connection* db) = 0;
 
   // Flatten the activity's type-specific fields into an ExtensionActivity.
   virtual scoped_ptr<api::activity_log_private::ExtensionActivity>
       ConvertToExtensionActivity() = 0;
 
   // Print an action as a regular string for debugging purposes.
   virtual std::string PrintForDebug() = 0;
 
   const std::string& extension_id() const { return extension_id_; }
   const base::Time& time() const { return time_; }
@@ skipping 24 matching lines @@
   base::Time time_;
   api::activity_log_private::ExtensionActivity::ActivityType activity_type_;
 
   DISALLOW_COPY_AND_ASSIGN(Action);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_ACTIVITY_ACTIONS_H_