Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: trunk/src/chrome/browser/extensions/activity_log/dom_actions.cc

Issue 16756004: Revert 205059 "We were seeing ActivityLog memory leaks and assor..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/activity_log/dom_actions.cc
===================================================================
--- trunk/src/chrome/browser/extensions/activity_log/dom_actions.cc (revision 205306)
+++ trunk/src/chrome/browser/extensions/activity_log/dom_actions.cc (working copy)
@@ -106,7 +106,7 @@
return initialized;
}
-bool DOMAction::Record(sql::Connection* db) {
+void DOMAction::Record(sql::Connection* db) {
std::string sql_str = "INSERT INTO " + std::string(kTableName) +
" (extension_id, time, url_action_type, url, url_title, api_call, args,"
" extra) VALUES (?,?,?,?,?,?,?,?)";
@@ -120,12 +120,8 @@
statement.BindString(5, api_call_);
statement.BindString(6, args_);
statement.BindString(7, extra_);
- if (!statement.Run()) {
+ if (!statement.Run())
LOG(ERROR) << "Activity log database I/O failed: " << sql_str;
- statement.Clear();
- return false;
- }
- return true;
}
std::string DOMAction::PrintForDebug() {
« no previous file with comments | « trunk/src/chrome/browser/extensions/activity_log/dom_actions.h ('k') | trunk/src/tools/heapcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698