Revert 205059 "We were seeing ActivityLog memory leaks and assor..."

trunk/src/chrome/browser/extensions/activity_log/blocked_actions.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/extensions/activity_log/blocked_actions.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
@@ skipping 77 matching lines @@
         return false;
     }
   }
   return InitializeTableInternal(db,
                                  kTableName,
                                  kTableContentFields,
                                  kTableFieldTypes,
                                  arraysize(kTableContentFields));
 }
 
-bool BlockedAction::Record(sql::Connection* db) {
+void BlockedAction::Record(sql::Connection* db) {
   std::string sql_str = "INSERT INTO " + std::string(kTableName)
     + " (extension_id, time, api_call, args, reason, extra)"
     "  VALUES (?,?,?,?,?,?)";
   sql::Statement statement(db->GetCachedStatement(
       sql::StatementID(SQL_FROM_HERE), sql_str.c_str()));
   statement.BindString(0, extension_id());
   statement.BindInt64(1, time().ToInternalValue());
   statement.BindString(2, api_call_);
   statement.BindString(3, args_);
   statement.BindInt(4, static_cast<int>(reason_));
   statement.BindString(5, extra_);
-  if (!statement.Run()) {
+  if (!statement.Run())
     LOG(ERROR) << "Activity log database I/O failed: " << sql_str;
-    statement.Clear();
-    return false;
-  } else {
-    return true;
-  }
 }
 
 std::string BlockedAction::PrintForDebug() {
   return "ID: " + extension_id() + ", blocked action " + api_call_ +
       ", reason: " + ReasonAsString();
 }
 
 std::string BlockedAction::ReasonAsString() const {
   if (reason_ == ACCESS_DENIED)
     return std::string("access_denied");
   else if (reason_ == QUOTA_EXCEEDED)
     return std::string("quota_exceeded");
   else
     return std::string("unknown_reason_type");  // To avoid Win header name.
 }
 
 }  // namespace extensions