Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, ahutter, mad+watch_chromium.org, gideonwald, dcheng, Dmitry Titov, browser-components-watch_chromium.org, Raman Kakilate, kinuko+watch, Ilya Sherman, vsevik, melevin+watch_chromium.org, benquan, dbeam+watch-autofill_chromium.org, dominich, marja+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, tim (not reviewing), pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, jennb, samarth+watch_chromium.org, Raghu Simha, jianli, jfweitz+watch_chromium.org, yoshiki+watch_chromium.org, kmadhusu+watch_chromium.org, Albert Bodenhamer, haitaol1, Jered, akalin, tfarina, donnd+watch_chromium.org, sreeram, yurys, Aaron Boodman, eroman, David Black, Dane Wallinga, dyu1, estade+watch_chromium.org, mmenke, pfeldman
Visibility:
Public.

Description

Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes, Part 4 of N BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+619 lines, -567 lines) Patch
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 7 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/database_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 18 chunks +54 lines, -46 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/two_phase_uploader.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/two_phase_uploader_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/iframe_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_io_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_service.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/base_session_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service_helper.cc View 3 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/signin/oauth2_token_service.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/signin/oauth2_token_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_cookie_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/token_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_preferences.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_add_cert_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_add_certificate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_client_auth_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_auth_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ssl/ssl_error_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_tab_helper.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/model_association_manager.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 8 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/sync/glue/non_ui_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc View 12 chunks +72 lines, -75 lines 0 comments Download
M chrome/browser/sync/glue/password_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/shared_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/ui_data_type_controller.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 9 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service_mock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store.cc View 12 chunks +63 lines, -31 lines 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/worker_resource_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_service_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_tab_helper.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/ssl_client_certificate_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/tabs/tab_audio_indicator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/app_launcher_page_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/import_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_proxy.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/session_favicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/usb/usb_device.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/usb/usb_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Sleevi
TBR
7 years, 6 months ago (2013-06-01 01:33:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/16290004/1
7 years, 6 months ago (2013-06-01 01:33:42 UTC) #2
commit-bot: I haz the power
7 years, 6 months ago (2013-06-03 00:11:02 UTC) #3
Message was sent while issue was closed. 
Change committed as 203648

Powered by Google App Engine
This is Rietveld 408576698