chrome/browser/ui/browser.cc - Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc ('k') | chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 9cb4c5f6de4e65f7ce389c837627dbb30e2ec867..510863ac7833b4eaabf93c45ab1ceed6b4362902 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -2196,12 +2196,12 @@ bool Browser::MaybeCreateBackgroundContents(int route_id,

content::SiteInstance::Create(opener_web_contents->GetBrowserContext());

// Passed all the checks, so this should be created as a BackgroundContents.

- BackgroundContents* contents = service->CreateBackgroundContents(

- site_instance,

- route_id,

- profile_,

- frame_name,

- ASCIIToUTF16(extension->id()));

+ BackgroundContents* contents =

+ service->CreateBackgroundContents(site_instance.get(),

+ route_id,

+ profile_,

+ frame_name,

+ ASCIIToUTF16(extension->id()));

// When a separate process is used, the original renderer cannot access the

// new window later, thus we need to navigate the window now.