chrome/browser/thumbnails/thumbnail_tab_helper.cc - Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_tab_helper.cc

Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/thumbnails/thumbnail_service_unittest.cc ('k') | chrome/browser/ui/autofill/autofill_popup_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/thumbnail_tab_helper.cc

diff --git a/chrome/browser/thumbnails/thumbnail_tab_helper.cc b/chrome/browser/thumbnails/thumbnail_tab_helper.cc

index c55920abbf1f0498273a9e53e608a8ecaec2cbf8..70604082d5db8b8430f5646490012a9341db41b8 100644

--- a/chrome/browser/thumbnails/thumbnail_tab_helper.cc

+++ b/chrome/browser/thumbnails/thumbnail_tab_helper.cc

@@ -206,7 +206,7 @@ void ThumbnailTabHelper::UpdateThumbnailIfNecessary(

ThumbnailServiceFactory::GetForProfile(profile);

// Skip if we don't need to update the thumbnail.

- if (thumbnail_service == NULL ||

+ if (thumbnail_service.get() == NULL ||

!thumbnail_service->ShouldAcquirePageThumbnail(url)) {

return;

}

@@ -214,10 +214,8 @@ void ThumbnailTabHelper::UpdateThumbnailIfNecessary(

scoped_refptr<thumbnails::ThumbnailingAlgorithm> algorithm(

thumbnail_service->GetThumbnailingAlgorithm());

- scoped_refptr<ThumbnailingContext> context(

- new ThumbnailingContext(web_contents,

- thumbnail_service,

- load_interrupted_));

+ scoped_refptr<ThumbnailingContext> context(new ThumbnailingContext(

+ web_contents, thumbnail_service.get(), load_interrupted_));

AsyncProcessThumbnail(web_contents, context, algorithm);

}