chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 16290004: Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index e0b6ec121dcb21d8e8ef3fc05895f3d0f3f06e11..6678557eed4667eb22a1566e479ac3156574e2c8 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -226,8 +226,7 @@ SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(

// reports.

if (unsafe_resources.size() == 1 &&

unsafe_resources[0].threat_type == SB_THREAT_TYPE_URL_MALWARE &&

- malware_details_ == NULL &&

- CanShowMalwareDetailsOption()) {

+ malware_details_.get() == NULL && CanShowMalwareDetailsOption()) {

malware_details_ = MalwareDetails::NewMalwareDetails(

ui_manager_, web_contents, unsafe_resources[0]);

}

@@ -702,7 +701,7 @@ void SafeBrowsingBlockingPage::RecordUserReactionTime(

}

void SafeBrowsingBlockingPage::FinishMalwareDetails(int64 delay_ms) {

- if (malware_details_ == NULL)

+ if (malware_details_.get() == NULL)

return; // Not all interstitials have malware details (eg phishing).

if (IsPrefEnabled(prefs::kSafeBrowsingReportingEnabled)) {