Move Extension::GetBasicInfo to a static helper.

Move Extension::GetBasicInfo to a static helper.

BUG=162530
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203928

[Yoyo Zhou, 2013-06-03 16:34:29]

ping

[James Hawkins, 2013-06-03 16:40:42]

You're going to need to get someone to review extensions/

[James Hawkins, 2013-06-03 16:43:56]

What is the rationale for this change?

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_basic_info.cc (right):

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_basic_info.cc:14: namespace
info_keys = extension_info_keys;
Does this save you anything?  You're already wrapping due to other params anywa.

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_basic_info.h (right):

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_basic_info.h:18: void
GetBasicInfo(const Extension* extension,
Optional nit: I have a feeling this function name may be ambiguous, i.e., it
still needs to have Extension in the name, e.g., GetExtensionBasicInfo.

[Yoyo Zhou, 2013-06-03 19:35:29]

The purpose of this change is to remove dependencies from extension.cc to Chrome
extension APIs, and ultimately to move extension.cc to the top-level extensions
directory. I've updated the BUG= to a more specific bug for this.

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_basic_info.cc (right):

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_basic_info.cc:14: namespace
info_keys = extension_info_keys;
On 2013/06/03 16:43:56, James Hawkins wrote:
> Does this save you anything?  You're already wrapping due to other params
anywa.

It turns out the values aren't used anywhere else in C++, so I just moved them
to an anonymous namespace here.

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/extension_basic_info.h (right):

https://chromiumcodereview.appspot.com/16248002/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/extension_basic_info.h:18: void
GetBasicInfo(const Extension* extension,
On 2013/06/03 16:43:56, James Hawkins wrote:
> Optional nit: I have a feeling this function name may be ambiguous, i.e., it
> still needs to have Extension in the name, e.g., GetExtensionBasicInfo.

Sure, renamed.

[James Hawkins, 2013-06-03 19:37:22]

lgtm

[Yoyo Zhou, 2013-06-03 20:57:12]

+mpcomplete: please review chrome/common/extensions

[Matt Perry, 2013-06-03 21:06:42]

lgtm

https://chromiumcodereview.appspot.com/16248002/diff/10001/chrome/browser/ui/...
File chrome/browser/ui/webui/extensions/extension_basic_info.cc (right):

https://chromiumcodereview.appspot.com/16248002/diff/10001/chrome/browser/ui/...
chrome/browser/ui/webui/extensions/extension_basic_info.cc:15: // Keys in the
dictionary returned by GetExtensionBasicInfo().
It's worth noting that these can't change and must match the management API.

[Yoyo Zhou, 2013-06-03 21:23:46]

https://chromiumcodereview.appspot.com/16248002/diff/10001/chrome/browser/ui/...
File chrome/browser/ui/webui/extensions/extension_basic_info.cc (right):

https://chromiumcodereview.appspot.com/16248002/diff/10001/chrome/browser/ui/...
chrome/browser/ui/webui/extensions/extension_basic_info.cc:15: // Keys in the
dictionary returned by GetExtensionBasicInfo().
On 2013/06/03 21:06:42, Matt Perry wrote:
> It's worth noting that these can't change and must match the management API.

There was a comment to this effect but I couldn't find where the management API
uses these values at all; I assumed it was wrong. GetBasicInfo was only being
used by WebUI.

[Matt Perry, 2013-06-03 21:29:12]

https://chromiumcodereview.appspot.com/16248002/diff/10001/chrome/browser/ui/...
File chrome/browser/ui/webui/extensions/extension_basic_info.cc (right):

https://chromiumcodereview.appspot.com/16248002/diff/10001/chrome/browser/ui/...
chrome/browser/ui/webui/extensions/extension_basic_info.cc:15: // Keys in the
dictionary returned by GetExtensionBasicInfo().
On 2013/06/03 21:23:47, Yoyo Zhou wrote:
> On 2013/06/03 21:06:42, Matt Perry wrote:
> > It's worth noting that these can't change and must match the management API.
> 
> There was a comment to this effect but I couldn't find where the management
API
> uses these values at all; I assumed it was wrong. GetBasicInfo was only being
> used by WebUI.

Oh right, that comment probably predates the JSON schema compiler.

[commit-bot: I haz the power, 2013-06-03 21:35:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/16248002/10001

[commit-bot: I haz the power, 2013-06-03 21:47:16]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-06-03 21:54:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/16248002/11003

[commit-bot: I haz the power, 2013-06-04 11:12:57]

Change committed as 203928