Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4043)

Unified Diff: chrome/common/extensions/extension.cc

Issue 16248002: Move Extension::GetBasicInfo to a static helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 720d8cf43b99800bd4915863be09da8dab64fa08..dc05f565cc5b1be762d878ab94a79f0a1c100169 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -31,8 +31,6 @@
#include "chrome/common/extensions/incognito_handler.h"
#include "chrome/common/extensions/manifest.h"
#include "chrome/common/extensions/manifest_handler.h"
-#include "chrome/common/extensions/manifest_handlers/kiosk_enabled_info.h"
-#include "chrome/common/extensions/manifest_handlers/offline_enabled_info.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "chrome/common/extensions/permissions/api_permission_set.h"
#include "chrome/common/extensions/permissions/permission_set.h"
@@ -57,7 +55,6 @@
namespace keys = extension_manifest_keys;
namespace values = extension_manifest_values;
namespace errors = extension_manifest_errors;
-namespace info_keys = extension_info_keys;
namespace extensions {
@@ -232,26 +229,6 @@ bool Extension::IsExtension(const base::FilePath& file_name) {
return file_name.MatchesExtension(chrome::kExtensionFileExtension);
}
-void Extension::GetBasicInfo(bool enabled,
- DictionaryValue* info) const {
- info->SetString(info_keys::kIdKey, id());
- info->SetString(info_keys::kNameKey, name());
- info->SetBoolean(info_keys::kEnabledKey, enabled);
- info->SetBoolean(info_keys::kKioskEnabledKey,
- KioskEnabledInfo::IsKioskEnabled(this));
- info->SetBoolean(info_keys::kOfflineEnabledKey,
- OfflineEnabledInfo::IsOfflineEnabled(this));
- info->SetString(info_keys::kVersionKey, VersionString());
- info->SetString(info_keys::kDescriptionKey, description());
- info->SetString(info_keys::kOptionsUrlKey,
- ManifestURL::GetOptionsPage(this).possibly_invalid_spec());
- info->SetString(info_keys::kHomepageUrlKey,
- ManifestURL::GetHomepageURL(this).possibly_invalid_spec());
- info->SetString(info_keys::kDetailsUrlKey,
- ManifestURL::GetDetailsURL(this).possibly_invalid_spec());
- info->SetBoolean(info_keys::kPackagedAppKey, is_platform_app());
-}
-
Manifest::Type Extension::GetType() const {
return converted_from_user_script() ?
Manifest::TYPE_USER_SCRIPT : manifest_->type();
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698