Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_info_ui.cc

Issue 16248002: Move Extension::GetBasicInfo to a static helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h"
6 6
7 #include "base/i18n/time_formatting.h" 7 #include "base/i18n/time_formatting.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
11 #include "chrome/browser/extensions/extension_prefs.h" 11 #include "chrome/browser/extensions/extension_prefs.h"
12 #include "chrome/browser/extensions/extension_service.h" 12 #include "chrome/browser/extensions/extension_service.h"
13 #include "chrome/browser/extensions/extension_system.h" 13 #include "chrome/browser/extensions/extension_system.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/webui/extensions/extension_basic_info.h"
15 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h" 16 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
16 #include "chrome/common/extensions/extension.h" 17 #include "chrome/common/extensions/extension.h"
17 #include "chrome/common/extensions/extension_constants.h" 18 #include "chrome/common/extensions/extension_constants.h"
18 #include "chrome/common/extensions/extension_icon_set.h" 19 #include "chrome/common/extensions/extension_icon_set.h"
19 #include "chrome/common/url_constants.h" 20 #include "chrome/common/url_constants.h"
20 #include "content/public/browser/web_ui.h" 21 #include "content/public/browser/web_ui.h"
21 #include "content/public/browser/web_ui_data_source.h" 22 #include "content/public/browser/web_ui_data_source.h"
22 #include "grit/browser_resources.h" 23 #include "grit/browser_resources.h"
23 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
24 25
(...skipping 30 matching lines...) Expand all
55 void ExtensionInfoUI::AddExtensionDataToSource( 56 void ExtensionInfoUI::AddExtensionDataToSource(
56 const std::string& extension_id) { 57 const std::string& extension_id) {
57 ExtensionService* extension_service = extensions::ExtensionSystem::Get( 58 ExtensionService* extension_service = extensions::ExtensionSystem::Get(
58 Profile::FromWebUI(web_ui()))->extension_service(); 59 Profile::FromWebUI(web_ui()))->extension_service();
59 const extensions::Extension* extension = 60 const extensions::Extension* extension =
60 extension_service->extensions()->GetByID(extension_id); 61 extension_service->extensions()->GetByID(extension_id);
61 if (!extension) 62 if (!extension)
62 return; 63 return;
63 64
64 DictionaryValue extension_data; 65 DictionaryValue extension_data;
65 extension->GetBasicInfo(true, &extension_data); 66 extensions::GetExtensionBasicInfo(extension, true, &extension_data);
66 source_->AddLocalizedStrings(extension_data); 67 source_->AddLocalizedStrings(extension_data);
67 68
68 // Set the icon URL. 69 // Set the icon URL.
69 GURL icon = 70 GURL icon =
70 ExtensionIconSource::GetIconURL(extension, 71 ExtensionIconSource::GetIconURL(extension,
71 extension_misc::EXTENSION_ICON_MEDIUM, 72 extension_misc::EXTENSION_ICON_MEDIUM,
72 ExtensionIconSet::MATCH_BIGGER, 73 ExtensionIconSet::MATCH_BIGGER,
73 false, NULL); 74 false, NULL);
74 source_->AddString("icon", UTF8ToUTF16(icon.spec())); 75 source_->AddString("icon", UTF8ToUTF16(icon.spec()));
75 // Set the last update time (the install time). 76 // Set the last update time (the install time).
76 base::Time install_time = extension_service->extension_prefs()-> 77 base::Time install_time = extension_service->extension_prefs()->
77 GetInstallTime(extension_id); 78 GetInstallTime(extension_id);
78 source_->AddString("installTime", base::TimeFormatShortDate(install_time)); 79 source_->AddString("installTime", base::TimeFormatShortDate(install_time));
79 } 80 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698