chrome/browser/ui/webui/extensions/extension_info_ui.cc - Issue 16248002: Move Extension::GetBasicInfo to a static helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_info_ui.cc

Issue 16248002: Move Extension::GetBasicInfo to a static helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/extensions/extension_info_ui.cc

diff --git a/chrome/browser/ui/webui/extensions/extension_info_ui.cc b/chrome/browser/ui/webui/extensions/extension_info_ui.cc

index 7e892e00613db559ec5b47935339a8ed06ba0a16..ce633676f3db06251a4612632e40e5ec903f9492 100644

--- a/chrome/browser/ui/webui/extensions/extension_info_ui.cc

+++ b/chrome/browser/ui/webui/extensions/extension_info_ui.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/webui/extensions/extension_basic_info.h"

#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_constants.h"

@@ -62,7 +63,7 @@ void ExtensionInfoUI::AddExtensionDataToSource(

return;

DictionaryValue extension_data;

- extension->GetBasicInfo(true, &extension_data);

+ extensions::GetExtensionBasicInfo(extension, true, &extension_data);

source_->AddLocalizedStrings(extension_data);

// Set the icon URL.