Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 16046003: Move webkit/gpu into webkit/common/gpu (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
CC:
chromium-reviews, jonathan.backer, Ian Vollick, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Move webkit/gpu into webkit/common/gpu The code in webkit/gpu is needed everywhere the compositor is used, which means both renderer and browser processes. This is a bit of a bummer but hard to fix immediately since the compositor uses WebKit::WebGraphicsContext3D. webkit/gpu itself only depends on the context type (which is just a vtable) and a couple exported functions from WebString, so it's not the end of the world to have it linked into every process. This moves the code into webkit/common/ to make this clearer. R=piman, joth BUG=237267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202341

Patch Set 1 #

Patch Set 2 : fix includes in content/common/gpu/client/gl_helper_* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -5788 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/gpu_memory_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/pixel_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gl_helper_benchmark.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittests.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/DEPS View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +1 line, -1 line 0 comments Download
A ui/compositor/test/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + webkit/common/gpu/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/common/gpu/context_provider_in_process.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + webkit/common/gpu/context_provider_in_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/common/gpu/gl_bindings_skia_cmd_buffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/gpu/gl_bindings_skia_cmd_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/gpu/grcontext_for_webgraphicscontext3d.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/gpu/grcontext_for_webgraphicscontext3d.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/gpu/test_context_provider_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/gpu/test_context_provider_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/common/gpu/webgraphicscontext3d_in_process_impl.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/gpu/webgraphicscontext3d_in_process_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/gpu/webgraphicscontext3d_provider_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webkit/common/gpu/webgraphicscontext3d_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/gpu/webkit_gpu.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/common/gpu/webkit_gpu_export.h View 2 chunks +3 lines, -3 lines 0 comments Download
D webkit/gpu/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D webkit/gpu/context_provider_in_process.h View 1 chunk +0 lines, -64 lines 0 comments Download
D webkit/gpu/context_provider_in_process.cc View 1 chunk +0 lines, -134 lines 0 comments Download
D webkit/gpu/gl_bindings_skia_cmd_buffer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/gpu/gl_bindings_skia_cmd_buffer.cc View 1 chunk +0 lines, -128 lines 0 comments Download
D webkit/gpu/grcontext_for_webgraphicscontext3d.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/gpu/grcontext_for_webgraphicscontext3d.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D webkit/gpu/test_context_provider_factory.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/gpu/test_context_provider_factory.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 1 chunk +0 lines, -610 lines 0 comments Download
D webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 1 chunk +0 lines, -2012 lines 0 comments Download
D webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 1 chunk +0 lines, -577 lines 0 comments Download
D webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 1 chunk +0 lines, -1813 lines 0 comments Download
D webkit/gpu/webgraphicscontext3d_provider_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/gpu/webgraphicscontext3d_provider_impl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D webkit/gpu/webkit_gpu.gyp View 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/gpu/webkit_gpu_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M webkit/renderer/compositor_bindings/compositor_bindings.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/support/web_layer_tree_view_impl_for_testing.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
7 years, 7 months ago (2013-05-24 23:29:28 UTC) #1
piman
lgtm
7 years, 7 months ago (2013-05-24 23:55:36 UTC) #2
jamesr
Thanks! TBRing joth@ for the mechanical android_webview changes
7 years, 7 months ago (2013-05-24 23:56:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16046003/1
7 years, 7 months ago (2013-05-24 23:57:03 UTC) #4
joth
lgtm
7 years, 7 months ago (2013-05-24 23:57:36 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-25 00:18:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16046003/13001
7 years, 7 months ago (2013-05-25 00:51:14 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 7 months ago (2013-05-26 02:44:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/16046003/13001
7 years, 7 months ago (2013-05-26 03:22:53 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-26 03:23:49 UTC) #10
Message was sent while issue was closed.
Change committed as 202341

Powered by Google App Engine
This is Rietveld 408576698