DescriptionUse DownloadItem::GetState() in chrome/
Stop using DownloadItem::Is*() functions that have an equivalent
state exposed via GetState(). Rationale is that there shouldn't be
multiple ways of getting the same state information.
To make review easier, this patch covers the remaining cases inside
chrome/. Changing content/ and DownloadItem itself to remove
the Is*() functions will come later.
BUG=241141
TEST=browser_tests and unit_tests both with *Download*:*SavePage* filters
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206076
Patch Set 1 #
Total comments: 5
Patch Set 2 : Update after asanka comments #Patch Set 3 : Remove assumption in download_item_view #Patch Set 4 : Rebased version #Patch Set 5 : Stopping complete_animation_ when download is cancelled #Messages
Total messages: 23 (0 generated)
|