chrome/browser/chromeos/drive/download_handler.cc - Issue 16018005: Use DownloadItem::GetState() in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/download_handler.cc

Issue 16018005: Use DownloadItem::GetState() in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Stopping complete_animation_ when download is cancelled Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/drive/download_handler.cc

diff --git a/chrome/browser/chromeos/drive/download_handler.cc b/chrome/browser/chromeos/drive/download_handler.cc

index ee46049e2ae3a3890e97185fcd19f99d389c1cd2..8e0bb33f983f31fc204a506edaca173e019a0fab 100644

--- a/chrome/browser/chromeos/drive/download_handler.cc

+++ b/chrome/browser/chromeos/drive/download_handler.cc

@@ -302,7 +302,7 @@ void DownloadHandler::OnCreateDirectory(

}

void DownloadHandler::UploadDownloadItem(DownloadItem* download) {

- DCHECK(download->IsComplete());

+ DCHECK_EQ(DownloadItem::COMPLETE, download->GetState());

file_write_helper_->PrepareWritableFileAndRun(

util::ExtractDrivePath(GetTargetPath(download)),

base::Bind(&MoveDownloadedFile, download->GetTargetFilePath()));