chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm - Issue 16018005: Use DownloadItem::GetState() in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

Issue 16018005: Use DownloadItem::GetState() in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Stopping complete_animation_ when download is cancelled Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/download/download_shelf_controller.mm ('k') | chrome/browser/ui/cocoa/download/download_util_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm b/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

index 60b51ac56bce543a4e14d68eb6611dcc37b70971..ed952c34248a0a301e5a27e2f47f97213e05d006 100644

--- a/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller_unittest.mm

@@ -119,8 +119,8 @@ id DownloadShelfControllerTest::CreateItemController() {

new ::testing::NiceMock<content::MockDownloadItem>);

ON_CALL(*download.get(), GetOpened())

.WillByDefault(Return(false));

- ON_CALL(*download.get(), IsInProgress())

- .WillByDefault(Return(true));

+ ON_CALL(*download.get(), GetState())

+ .WillByDefault(Return(content::DownloadItem::IN_PROGRESS));

scoped_nsobject<WrappedMockDownloadItem> wrappedMockDownload(

[[WrappedMockDownloadItem alloc] initWithMockDownload:download.Pass()]);