Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 15995026: Image filters: implement offsets in GPU path. (Closed)

Created:
7 years, 6 months ago by Stephen White
Modified:
7 years, 5 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Implement offset for GPU filter path. Although we can't yet use this in Blink for FEOffset, due to SVG semantics, we can use it to support crop rect (upcoming patch). This patch adds the parameter to the filterImageGPU() signature, plumbs through the code on the GPU side, and implements support for it in SkXfermodeImageFilter for both raster and GPU. Of the remaining filters with GPU implementations, Blur, Morphology, Bicubic and Displacement work fine; they're commutative wrt offset and can simply pass it up the chain. Blend is not, but will be removed shortly anyway (has been replaced with SkXfermodeImageFilter in Blink). Committed: http://code.google.com/p/skia/source/detail?r=9977

Patch Set 1 #

Patch Set 2 : Fix SkXfermodeImageFilter; add tests. #

Patch Set 3 : Wrap lines at 100 chars. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -67 lines) Patch
M gm/xfermodeimagefilter.cpp View 1 2 4 chunks +39 lines, -2 lines 0 comments Download
M include/core/SkImageFilter.h View 1 chunk +4 lines, -3 lines 0 comments Download
M include/core/SkImageFilterUtils.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkBicubicImageFilter.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M include/effects/SkBlendImageFilter.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkDisplacementMapEffect.h View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M include/effects/SkImageFilterUtils.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkImageFilterUtils.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/effects/SkBicubicImageFilter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 2 8 chunks +39 lines, -14 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 4 chunks +36 lines, -10 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 6 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Stephen White
Implement offset for GPU filter path. Although we can't yet use this in Blink for ...
7 years, 5 months ago (2013-07-10 20:18:19 UTC) #1
Stephen White
PTAL. Thanks!
7 years, 5 months ago (2013-07-10 20:19:18 UTC) #2
bsalomon
On 2013/07/10 20:19:18, Stephen White wrote: > PTAL. Thanks! nit: line wraps otherwise lgtm.
7 years, 5 months ago (2013-07-10 20:26:29 UTC) #3
reed1
what he said
7 years, 5 months ago (2013-07-10 20:29:58 UTC) #4
Stephen White
On 2013/07/10 20:26:29, bsalomon wrote: > On 2013/07/10 20:19:18, Stephen White wrote: > > PTAL. ...
7 years, 5 months ago (2013-07-10 21:00:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/15995026/20002
7 years, 5 months ago (2013-07-10 21:02:25 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-10 21:22:26 UTC) #7
Message was sent while issue was closed.
Change committed as 9977

Powered by Google App Engine
This is Rietveld 408576698