Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 15829004: Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed)

Created:
7 years, 6 months ago by Ryan Sleevi
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, gavinp+disk_chromium.org, ben+watch_chromium.org, erikwright (departed), sail+watch_chromium.org, Paweł Hajdan Jr., mmenke
Visibility:
Public.

Description

Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*" Linux fixes BUG=110610 TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203535

Patch Set 1 #

Patch Set 2 : Iterator fixes #

Patch Set 3 : license twerk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3647 lines, -2877 lines) Patch
M net/base/file_stream_context.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M net/base/file_stream_context_posix.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/base/file_stream_unittest.cc View 20 chunks +33 lines, -36 lines 0 comments Download
M net/base/test_completion_callback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_bytes_element_reader_unittest.cc View 4 chunks +17 lines, -11 lines 0 comments Download
M net/base/upload_data_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/upload_data_stream_unittest.cc View 15 chunks +41 lines, -29 lines 0 comments Download
M net/base/upload_file_element_reader.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/base/upload_file_element_reader_unittest.cc View 13 chunks +51 lines, -34 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 29 chunks +138 lines, -56 lines 0 comments Download
M net/cert/mock_cert_verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/multi_threaded_cert_verifier.cc View 4 chunks +19 lines, -7 lines 0 comments Download
M net/cert/multi_threaded_cert_verifier_unittest.cc View 12 chunks +97 lines, -37 lines 0 comments Download
M net/cert/nss_cert_database.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 20 chunks +129 lines, -71 lines 0 comments Download
M net/cert/test_root_certs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M net/cookies/cookie_monster_perftest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M net/cookies/cookie_monster_store_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 60 chunks +464 lines, -305 lines 0 comments Download
M net/cookies/cookie_store_test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_store_unittest.h View 22 chunks +333 lines, -282 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 19 chunks +48 lines, -43 lines 0 comments Download
M net/disk_cache/block_files.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/cache_creator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/disk_cache/disk_cache_perftest.cc View 3 chunks +20 lines, -6 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/entry_unittest.cc View 72 chunks +427 lines, -280 lines 0 comments Download
M net/disk_cache/file_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/flash/flash_entry_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/disk_cache/flash/internal_entry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/flash/log_store_entry_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/in_flight_backend_io.cc View 8 chunks +41 lines, -31 lines 0 comments Download
M net/disk_cache/in_flight_io.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 11 chunks +40 lines, -19 lines 0 comments Download
M net/disk_cache/storage_block_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/dns/dns_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_query.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_transaction.cc View 7 chunks +23 lines, -24 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/dns/host_resolver_impl_unittest.cc View 4 chunks +14 lines, -17 lines 0 comments Download
M net/dns/host_resolver_proc.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/dns/mock_host_resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mock_host_resolver.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/dns/serial_worker.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/ftp/ftp_network_layer.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M net/http/http_auth_controller.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M net/http/http_basic_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_cache.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M net/http/http_cache_transaction.cc View 20 chunks +36 lines, -32 lines 0 comments Download
M net/http/http_cache_unittest.cc View 22 chunks +40 lines, -34 lines 0 comments Download
M net/http/http_network_layer.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/http/http_network_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 10 chunks +16 lines, -13 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 176 chunks +197 lines, -198 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 176 chunks +196 lines, -196 lines 0 comments Download
M net/http/http_network_transaction_ssl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_pipelined_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_body_drainer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 10 chunks +26 lines, -20 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_stream_parser.cc View 8 chunks +25 lines, -26 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/http/http_transaction_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_vary_data_unittest.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M net/http/mock_http_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/proxy_client_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ocsp/nss_ocsp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ocsp/nss_ocsp_unittest.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M net/proxy/mock_proxy_resolver.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/proxy/mock_proxy_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/multi_threaded_proxy_resolver.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/polling_proxy_config_service.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/proxy/proxy_service.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_connection_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_http_stream.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/server/http_connection.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/server/http_server.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/buffered_write_stream_socket.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/socket/client_socket_factory.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 2 chunks +17 lines, -18 lines 0 comments Download
M net/socket/deterministic_socket_data_unittest.cc View 5 chunks +33 lines, -15 lines 0 comments Download
M net/socket/socks5_client_socket.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/socket/socks5_client_socket_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/socket/socks_client_socket.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 18 chunks +34 lines, -29 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 22 chunks +34 lines, -32 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 8 chunks +10 lines, -8 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 9 chunks +23 lines, -23 lines 0 comments Download
M net/socket/tcp_listen_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/tcp_listen_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_server_socket_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/socket/transport_client_socket_unittest.cc View 14 chunks +22 lines, -20 lines 0 comments Download
M net/socket/unix_domain_socket_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 14 chunks +26 lines, -26 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 8 chunks +14 lines, -13 lines 0 comments Download
M net/spdy/spdy_http_stream_spdy2_unittest.cc View 3 chunks +13 lines, -15 lines 0 comments Download
M net/spdy/spdy_http_stream_spdy3_unittest.cc View 4 chunks +15 lines, -18 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy2_unittest.cc View 64 chunks +89 lines, -87 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 65 chunks +91 lines, -89 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 17 chunks +29 lines, -24 lines 0 comments Download
M net/spdy/spdy_session.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_session_spdy2_unittest.cc View 4 chunks +16 lines, -9 lines 0 comments Download
M net/spdy/spdy_session_spdy3_unittest.cc View 12 chunks +25 lines, -19 lines 0 comments Download
M net/spdy/spdy_stream.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M net/spdy/spdy_stream_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/spdy_websocket_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_websocket_stream_spdy2_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/spdy_websocket_stream_spdy3_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/ssl/client_cert_store_impl_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/ssl/default_server_bound_cert_store.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/default_server_bound_cert_store.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/ssl/server_bound_cert_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ssl/ssl_client_auth_cache_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/ssl/ssl_info.h View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/simple_cache_dumper.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/fetch/http_listen_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket_libevent.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/udp/udp_socket_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M net/url_request/test_url_fetcher_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_fetcher_core.cc View 14 chunks +27 lines, -25 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M net/url_request/url_fetcher_response_writer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/url_request/url_request.cc View 18 chunks +31 lines, -31 lines 0 comments Download
M net/url_request/url_request_context.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/url_request/url_request_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_ftp_job.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 6 chunks +10 lines, -8 lines 0 comments Download
M net/url_request/url_request_job.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_throttler_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/url_request/view_cache_helper.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M net/url_request/view_cache_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_job.cc View 13 chunks +26 lines, -24 lines 0 comments Download
M net/websockets/websocket_job_spdy2_unittest.cc View 9 chunks +16 lines, -18 lines 0 comments Download
M net/websockets/websocket_job_spdy3_unittest.cc View 9 chunks +16 lines, -18 lines 0 comments Download
M net/websockets/websocket_throttle_unittest.cc View 9 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
TBR=darin
7 years, 6 months ago (2013-05-31 19:42:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15829004/2001
7 years, 6 months ago (2013-05-31 19:43:59 UTC) #2
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6178
7 years, 6 months ago (2013-05-31 19:58:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/15829004/9001
7 years, 6 months ago (2013-05-31 20:04:17 UTC) #4
darin (slow to review)
LGTM
7 years, 6 months ago (2013-05-31 22:27:29 UTC) #5
commit-bot: I haz the power
7 years, 6 months ago (2013-06-01 00:39:53 UTC) #6
Message was sent while issue was closed.
Change committed as 203535

Powered by Google App Engine
This is Rietveld 408576698