Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: net/udp/udp_socket_unittest.cc

Issue 15829004: Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: license twerk Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/udp/udp_socket_libevent.cc ('k') | net/url_request/test_url_fetcher_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/udp/udp_socket_unittest.cc
diff --git a/net/udp/udp_socket_unittest.cc b/net/udp/udp_socket_unittest.cc
index d488bea46da6654b248f26800e8fb55f3f1a1ca5..ffb56d98141d13700496894e65c526d086af33e0 100644
--- a/net/udp/udp_socket_unittest.cc
+++ b/net/udp/udp_socket_unittest.cc
@@ -33,8 +33,8 @@ class UDPSocketTest : public PlatformTest {
std::string RecvFromSocket(UDPServerSocket* socket) {
TestCompletionCallback callback;
- int rv = socket->RecvFrom(buffer_, kMaxRead, &recv_from_address_,
- callback.callback());
+ int rv = socket->RecvFrom(
+ buffer_.get(), kMaxRead, &recv_from_address_, callback.callback());
if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
if (rv < 0)
@@ -59,12 +59,12 @@ class UDPSocketTest : public PlatformTest {
int length = msg.length();
scoped_refptr<StringIOBuffer> io_buffer(new StringIOBuffer(msg));
scoped_refptr<DrainableIOBuffer> buffer(
- new DrainableIOBuffer(io_buffer, length));
+ new DrainableIOBuffer(io_buffer.get(), length));
int bytes_sent = 0;
while (buffer->BytesRemaining()) {
- int rv = socket->SendTo(buffer, buffer->BytesRemaining(),
- address, callback.callback());
+ int rv = socket->SendTo(
+ buffer.get(), buffer->BytesRemaining(), address, callback.callback());
if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
if (rv <= 0)
@@ -78,7 +78,7 @@ class UDPSocketTest : public PlatformTest {
std::string ReadSocket(UDPClientSocket* socket) {
TestCompletionCallback callback;
- int rv = socket->Read(buffer_, kMaxRead, callback.callback());
+ int rv = socket->Read(buffer_.get(), kMaxRead, callback.callback());
if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
if (rv < 0)
@@ -94,12 +94,12 @@ class UDPSocketTest : public PlatformTest {
int length = msg.length();
scoped_refptr<StringIOBuffer> io_buffer(new StringIOBuffer(msg));
scoped_refptr<DrainableIOBuffer> buffer(
- new DrainableIOBuffer(io_buffer, length));
+ new DrainableIOBuffer(io_buffer.get(), length));
int bytes_sent = 0;
while (buffer->BytesRemaining()) {
- int rv = socket->Write(buffer, buffer->BytesRemaining(),
- callback.callback());
+ int rv = socket->Write(
+ buffer.get(), buffer->BytesRemaining(), callback.callback());
if (rv == ERR_IO_PENDING)
rv = callback.WaitForResult();
if (rv <= 0)
@@ -518,7 +518,7 @@ TEST_F(UDPSocketTest, CloseWithPendingRead) {
TestCompletionCallback callback;
IPEndPoint from;
- rv = server.RecvFrom(buffer_, kMaxRead, &from, callback.callback());
+ rv = server.RecvFrom(buffer_.get(), kMaxRead, &from, callback.callback());
EXPECT_EQ(rv, ERR_IO_PENDING);
server.Close();
« no previous file with comments | « net/udp/udp_socket_libevent.cc ('k') | net/url_request/test_url_fetcher_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698