Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: net/http/http_auth_controller.cc

Issue 15829004: Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: license twerk Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_network_transaction.cc ('k') | net/http/http_basic_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_controller.cc
diff --git a/net/http/http_auth_controller.cc b/net/http/http_auth_controller.cc
index ae396402c111afe6912c0f7ffdcf7df9d5d41aa5..00b30d759079e2c3dd497a29f3304d3181999b9a 100644
--- a/net/http/http_auth_controller.cc
+++ b/net/http/http_auth_controller.cc
@@ -251,7 +251,7 @@ int HttpAuthController::HandleAuthChallenge(
bool establishing_tunnel,
const BoundNetLog& net_log) {
DCHECK(CalledOnValidThread());
- DCHECK(headers);
+ DCHECK(headers.get());
DCHECK(auth_origin_.is_valid());
VLOG(1) << "The " << HttpAuth::GetAuthTargetString(target_) << " "
<< auth_origin_ << " requested auth "
@@ -263,8 +263,12 @@ int HttpAuthController::HandleAuthChallenge(
// case.
if (HaveAuth()) {
std::string challenge_used;
- HttpAuth::AuthorizationResult result = HttpAuth::HandleChallengeResponse(
- handler_.get(), headers, target_, disabled_schemes_, &challenge_used);
+ HttpAuth::AuthorizationResult result =
+ HttpAuth::HandleChallengeResponse(handler_.get(),
+ headers.get(),
+ target_,
+ disabled_schemes_,
+ &challenge_used);
switch (result) {
case HttpAuth::AUTHORIZATION_RESULT_ACCEPT:
break;
@@ -314,8 +318,11 @@ int HttpAuthController::HandleAuthChallenge(
if (!handler_.get() && can_send_auth) {
// Find the best authentication challenge that we support.
HttpAuth::ChooseBestChallenge(http_auth_handler_factory_,
- headers, target_, auth_origin_,
- disabled_schemes_, net_log,
+ headers.get(),
+ target_,
+ auth_origin_,
+ disabled_schemes_,
+ net_log,
&handler_);
if (handler_.get())
HistogramAuthEvent(handler_.get(), AUTH_EVENT_START);
« no previous file with comments | « net/ftp/ftp_network_transaction.cc ('k') | net/http/http_basic_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698