Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Side by Side Diff: net/ssl/ssl_client_auth_cache_unittest.cc

Issue 15829004: Update net/ to use scoped_refptr<T>::get() rather than implicit "operator T*" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: license twerk Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/ssl/server_bound_cert_service_unittest.cc ('k') | net/ssl/ssl_info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ssl/ssl_client_auth_cache.h" 5 #include "net/ssl/ssl_client_auth_cache.h"
6 6
7 #include "base/time.h" 7 #include "base/time.h"
8 #include "net/cert/x509_certificate.h" 8 #include "net/cert/x509_certificate.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 16 matching lines...) Expand all
27 std::string server3("foo3:443"); 27 std::string server3("foo3:443");
28 scoped_refptr<X509Certificate> cert3( 28 scoped_refptr<X509Certificate> cert3(
29 new X509Certificate("foo3", "CA", start_date, expiration_date)); 29 new X509Certificate("foo3", "CA", start_date, expiration_date));
30 30
31 scoped_refptr<X509Certificate> cached_cert; 31 scoped_refptr<X509Certificate> cached_cert;
32 // Lookup non-existent client certificate. 32 // Lookup non-existent client certificate.
33 cached_cert = NULL; 33 cached_cert = NULL;
34 EXPECT_FALSE(cache.Lookup(server1, &cached_cert)); 34 EXPECT_FALSE(cache.Lookup(server1, &cached_cert));
35 35
36 // Add client certificate for server1. 36 // Add client certificate for server1.
37 cache.Add(server1, cert1); 37 cache.Add(server1, cert1.get());
38 cached_cert = NULL; 38 cached_cert = NULL;
39 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 39 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
40 EXPECT_EQ(cert1, cached_cert); 40 EXPECT_EQ(cert1, cached_cert);
41 41
42 // Add client certificate for server2. 42 // Add client certificate for server2.
43 cache.Add(server2, cert2); 43 cache.Add(server2, cert2.get());
44 cached_cert = NULL; 44 cached_cert = NULL;
45 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 45 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
46 EXPECT_EQ(cert1, cached_cert.get()); 46 EXPECT_EQ(cert1, cached_cert.get());
47 cached_cert = NULL; 47 cached_cert = NULL;
48 EXPECT_TRUE(cache.Lookup(server2, &cached_cert)); 48 EXPECT_TRUE(cache.Lookup(server2, &cached_cert));
49 EXPECT_EQ(cert2, cached_cert); 49 EXPECT_EQ(cert2, cached_cert);
50 50
51 // Overwrite the client certificate for server1. 51 // Overwrite the client certificate for server1.
52 cache.Add(server1, cert3); 52 cache.Add(server1, cert3.get());
53 cached_cert = NULL; 53 cached_cert = NULL;
54 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 54 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
55 EXPECT_EQ(cert3, cached_cert); 55 EXPECT_EQ(cert3, cached_cert);
56 cached_cert = NULL; 56 cached_cert = NULL;
57 EXPECT_TRUE(cache.Lookup(server2, &cached_cert)); 57 EXPECT_TRUE(cache.Lookup(server2, &cached_cert));
58 EXPECT_EQ(cert2, cached_cert); 58 EXPECT_EQ(cert2, cached_cert);
59 59
60 // Remove client certificate of server1. 60 // Remove client certificate of server1.
61 cache.Remove(server1); 61 cache.Remove(server1);
62 cached_cert = NULL; 62 cached_cert = NULL;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 // declined to send a certificate to |server1|. 118 // declined to send a certificate to |server1|.
119 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 119 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
120 EXPECT_EQ(NULL, cached_cert.get()); 120 EXPECT_EQ(NULL, cached_cert.get());
121 121
122 // Remove the existing cached certificate. 122 // Remove the existing cached certificate.
123 cache.Remove(server1); 123 cache.Remove(server1);
124 cached_cert = NULL; 124 cached_cert = NULL;
125 EXPECT_FALSE(cache.Lookup(server1, &cached_cert)); 125 EXPECT_FALSE(cache.Lookup(server1, &cached_cert));
126 126
127 // Add a new preference for a specific certificate. 127 // Add a new preference for a specific certificate.
128 cache.Add(server1, cert1); 128 cache.Add(server1, cert1.get());
129 cached_cert = NULL; 129 cached_cert = NULL;
130 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 130 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
131 EXPECT_EQ(cert1, cached_cert); 131 EXPECT_EQ(cert1, cached_cert);
132 132
133 // Replace the specific preference with a NULL certificate. 133 // Replace the specific preference with a NULL certificate.
134 cache.Add(server1, NULL); 134 cache.Add(server1, NULL);
135 cached_cert = NULL; 135 cached_cert = NULL;
136 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 136 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
137 EXPECT_EQ(NULL, cached_cert.get()); 137 EXPECT_EQ(NULL, cached_cert.get());
138 } 138 }
139 139
140 // Check that the OnCertAdded() method removes all cache entries. 140 // Check that the OnCertAdded() method removes all cache entries.
141 TEST(SSLClientAuthCacheTest, OnCertAdded) { 141 TEST(SSLClientAuthCacheTest, OnCertAdded) {
142 SSLClientAuthCache cache; 142 SSLClientAuthCache cache;
143 base::Time start_date = base::Time::Now(); 143 base::Time start_date = base::Time::Now();
144 base::Time expiration_date = start_date + base::TimeDelta::FromDays(1); 144 base::Time expiration_date = start_date + base::TimeDelta::FromDays(1);
145 145
146 std::string server1("foo:443"); 146 std::string server1("foo:443");
147 scoped_refptr<X509Certificate> cert1( 147 scoped_refptr<X509Certificate> cert1(
148 new X509Certificate("foo", "CA", start_date, expiration_date)); 148 new X509Certificate("foo", "CA", start_date, expiration_date));
149 149
150 cache.Add(server1, cert1); 150 cache.Add(server1, cert1.get());
151 151
152 std::string server2("foo2:443"); 152 std::string server2("foo2:443");
153 cache.Add(server2, NULL); 153 cache.Add(server2, NULL);
154 154
155 scoped_refptr<X509Certificate> cached_cert; 155 scoped_refptr<X509Certificate> cached_cert;
156 156
157 // Demonstrate the set up is correct. 157 // Demonstrate the set up is correct.
158 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 158 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
159 EXPECT_EQ(cert1, cached_cert); 159 EXPECT_EQ(cert1, cached_cert);
160 160
161 EXPECT_TRUE(cache.Lookup(server2, &cached_cert)); 161 EXPECT_TRUE(cache.Lookup(server2, &cached_cert));
162 EXPECT_EQ(NULL, cached_cert.get()); 162 EXPECT_EQ(NULL, cached_cert.get());
163 163
164 cache.OnCertAdded(NULL); 164 cache.OnCertAdded(NULL);
165 165
166 // Check that we no longer have entries for either server. 166 // Check that we no longer have entries for either server.
167 EXPECT_FALSE(cache.Lookup(server1, &cached_cert)); 167 EXPECT_FALSE(cache.Lookup(server1, &cached_cert));
168 EXPECT_FALSE(cache.Lookup(server2, &cached_cert)); 168 EXPECT_FALSE(cache.Lookup(server2, &cached_cert));
169 } 169 }
170 170
171 } // namespace net 171 } // namespace net
OLDNEW
« no previous file with comments | « net/ssl/server_bound_cert_service_unittest.cc ('k') | net/ssl/ssl_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698