Page::chrome() should return a reference.

Page::chrome() should return a reference.

A Page's chrome() can never be null. Change Page::chrome() to return a reference
to reflect this.  Also, make Page::m_chrome a const member variable so nobody
will accidentally set it to null.

Merge http://trac.webkit.org/changeset/150214 by akling.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151153

[haraken, 2013-05-24 00:02:44]

LGTM

[commit-bot: I haz the power, 2013-05-24 00:14:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/3001

[commit-bot: I haz the power, 2013-05-24 01:35:30]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-24 02:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/3001

[commit-bot: I haz the power, 2013-05-24 04:03:55]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-24 10:28:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/3001

[commit-bot: I haz the power, 2013-05-24 12:35:14]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-24 17:27:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/3001

[commit-bot: I haz the power, 2013-05-24 21:28:16]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-24 22:04:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/3001

[commit-bot: I haz the power, 2013-05-24 22:04:12]

Failed to apply patch for Source/WebKit/chromium/src/WebViewImpl.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/WebKit/chromium/src/WebViewImpl.cpp
  Hunk #1 succeeded at 1554 (offset -8 lines).
  Hunk #2 FAILED at 1636.
  Hunk #3 FAILED at 2998.
  Hunk #4 FAILED at 3658.
  3 out of 4 hunks FAILED -- saving rejects to file
Source/WebKit/chromium/src/WebViewImpl.cpp.rej

Patch:       Source/WebKit/chromium/src/WebViewImpl.cpp
Index: Source/WebKit/chromium/src/WebViewImpl.cpp
diff --git a/Source/WebKit/chromium/src/WebViewImpl.cpp
b/Source/WebKit/chromium/src/WebViewImpl.cpp
index
6d0350878a1439b6c76b23d92fbe8008532e206f..64716cbee34c8157fb4f8a7a7c7f3ba547e940e2
100644
--- a/Source/WebKit/chromium/src/WebViewImpl.cpp
+++ b/Source/WebKit/chromium/src/WebViewImpl.cpp
@@ -1562,7 +1562,7 @@ WebViewImpl* WebViewImpl::fromPage(Page* page)
     if (!page)
         return 0;
 
-    ChromeClientImpl* chromeClient =
static_cast<ChromeClientImpl*>(page->chrome()->client());
+    ChromeClientImpl* chromeClient =
static_cast<ChromeClientImpl*>(page->chrome().client());
     return static_cast<WebViewImpl*>(chromeClient->webView());
 }
 
@@ -1636,7 +1636,7 @@ void WebViewImpl::resize(const WebSize& newSize)
     }
 
     ViewportArguments viewportArguments =
mainFrameImpl()->frame()->document()->viewportArguments();
-   
m_page->chrome()->client()->dispatchViewportPropertiesDidChange(viewportArguments);
+   
m_page->chrome().client()->dispatchViewportPropertiesDidChange(viewportArguments);
 
     WebDevToolsAgentPrivate* agentPrivate = devToolsAgentPrivate();
     if (agentPrivate)
@@ -2998,7 +2998,7 @@ void WebViewImpl::setIgnoreViewportTagMaximumScale(bool
flag)
     if (!page() || !page()->mainFrame())
         return;
 
-   
m_page->chrome()->client()->dispatchViewportPropertiesDidChange(page()->mainFrame()->document()->viewportArguments());
+   
m_page->chrome().client()->dispatchViewportPropertiesDidChange(page()->mainFrame()->document()->viewportArguments());
 }
 
 IntSize WebViewImpl::contentsSize() const
@@ -3658,7 +3658,7 @@ void WebViewImpl::layoutUpdated(WebFrameImpl* webframe)
             // If the viewport tag failed to be processed earlier, we need
             // to recompute it now.
             ViewportArguments viewportArguments =
mainFrameImpl()->frame()->document()->viewportArguments();
-           
m_page->chrome()->client()->dispatchViewportPropertiesDidChange(viewportArguments);
+           
m_page->chrome().client()->dispatchViewportPropertiesDidChange(viewportArguments);
         }
 
         // Contents size is an input to the page scale limits, so a good time
to

[commit-bot: I haz the power, 2013-05-25 00:30:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/47001

[commit-bot: I haz the power, 2013-05-25 01:57:48]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-25 02:12:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/47001

[commit-bot: I haz the power, 2013-05-25 05:18:22]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-25 11:59:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/15820002/47001

[commit-bot: I haz the power, 2013-05-25 13:02:20]

Change committed as 151153