Source/core/html/TextFieldInputType.cpp - Issue 15820002: Page::chrome() should return a reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/TextFieldInputType.cpp

Issue 15820002: Page::chrome() should return a reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/TextFieldInputType.cpp

diff --git a/Source/core/html/TextFieldInputType.cpp b/Source/core/html/TextFieldInputType.cpp

index e042e98343c9999ed4a491304de1ef6f54c6c8e3..92a46762785e8819748345394f986f133468b2b1 100644

--- a/Source/core/html/TextFieldInputType.cpp

+++ b/Source/core/html/TextFieldInputType.cpp

@@ -231,7 +231,7 @@ void TextFieldInputType::createShadowSubtree()

ASSERT(!m_innerSpinButton);

Document* document = element()->document();

- ChromeClient* chromeClient = document->page() ? document->page()->chrome()->client() : 0;

+ ChromeClient* chromeClient = document->page() ? document->page()->chrome().client() : 0;

bool shouldAddDecorations = chromeClient && chromeClient->willAddTextFieldDecorationsTo(element());

bool shouldHaveSpinButton = this->shouldHaveSpinButton();

bool createsContainer = shouldHaveSpinButton || needsContainer() || shouldAddDecorations;

« no previous file with comments | « Source/core/html/InputType.cpp ('k') | Source/core/html/shadow/PickerIndicatorElement.cpp » ('j') | no next file with comments »