Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1699)

Unified Diff: Source/core/testing/Internals.cpp

Issue 15820002: Page::chrome() should return a reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index 82eb856c766a10a4b0afe434f69c845935d3eb35..eebafa4653dde4fec2ad3a5af2c3c4ed3c53a053 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -202,8 +202,7 @@ void Internals::resetToConsistentState(Page* page)
WebCore::Settings::setUsesOverlayScrollbars(false);
delete s_pagePopupDriver;
s_pagePopupDriver = 0;
- if (page->chrome())
- page->chrome()->client()->resetPagePopupDriver();
+ page->chrome().client()->resetPagePopupDriver();
if (page->inspectorController())
page->inspectorController()->setProfilerEnabled(false);
page->group().captionPreferences()->setTestingMode(false);
@@ -734,16 +733,16 @@ void Internals::enableMockSpeechSynthesizer()
void Internals::setEnableMockPagePopup(bool enabled, ExceptionCode& ec)
{
Document* document = contextDocument();
- if (!document || !document->page() || !document->page()->chrome())
+ if (!document || !document->page())
return;
Page* page = document->page();
if (!enabled) {
- page->chrome()->client()->resetPagePopupDriver();
+ page->chrome().client()->resetPagePopupDriver();
return;
}
if (!s_pagePopupDriver)
s_pagePopupDriver = MockPagePopupDriver::create(page->mainFrame()).leakPtr();
- page->chrome()->client()->setPagePopupDriver(s_pagePopupDriver);
+ page->chrome().client()->setPagePopupDriver(s_pagePopupDriver);
}
PassRefPtr<PagePopupController> Internals::pagePopupController()
« no previous file with comments | « Source/core/svg/SVGAElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698