Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: Source/core/svg/SVGAElement.cpp

Issue 15820002: Page::chrome() should return a reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/svg/RenderSVGRoot.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 222
223 bool SVGAElement::isKeyboardFocusable(KeyboardEvent*) const 223 bool SVGAElement::isKeyboardFocusable(KeyboardEvent*) const
224 { 224 {
225 if (!isFocusable()) 225 if (!isFocusable())
226 return false; 226 return false;
227 227
228 Page* page = document()->page(); 228 Page* page = document()->page();
229 if (!page) 229 if (!page)
230 return false; 230 return false;
231 231
232 return page->chrome()->client()->tabsToLinks(); 232 return page->chrome().client()->tabsToLinks();
233 } 233 }
234 234
235 bool SVGAElement::childShouldCreateRenderer(const NodeRenderingContext& childCon text) const 235 bool SVGAElement::childShouldCreateRenderer(const NodeRenderingContext& childCon text) const
236 { 236 {
237 // http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environm ent 237 // http://www.w3.org/2003/01/REC-SVG11-20030114-errata#linking-text-environm ent
238 // The 'a' element may contain any element that its parent may contain, exce pt itself. 238 // The 'a' element may contain any element that its parent may contain, exce pt itself.
239 if (childContext.node()->hasTagName(SVGNames::aTag)) 239 if (childContext.node()->hasTagName(SVGNames::aTag))
240 return false; 240 return false;
241 if (parentNode() && parentNode()->isSVGElement()) 241 if (parentNode() && parentNode()->isSVGElement())
242 return parentNode()->childShouldCreateRenderer(childContext); 242 return parentNode()->childShouldCreateRenderer(childContext);
243 243
244 return SVGElement::childShouldCreateRenderer(childContext); 244 return SVGElement::childShouldCreateRenderer(childContext);
245 } 245 }
246 246
247 } // namespace WebCore 247 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGRoot.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698