Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed)

Created:
7 years, 6 months ago by csharp
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Raman Kakilate, benquan, tfarina, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Autofill] Determine Popup RTLness from page Have the Autofill popup determine if it is RTL based on the element it is a popup for, instead of just following the RTL setting of the UI. BUG=238055 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205795

Patch Set 1 #

Patch Set 2 : Fix android compile #

Total comments: 4

Patch Set 3 : Responding to comments #

Total comments: 4

Patch Set 4 : Rebasing #

Patch Set 5 : Responding to comments #

Total comments: 2

Patch Set 6 : Using IPC_ENUM_TRAITS_MAX_VALUE #

Patch Set 7 : Rebase #

Patch Set 8 : Fix android compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -33 lines) Patch
M android_webview/browser/aw_autofill_manager_delegate.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_autofill_manager_delegate.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M base/i18n/rtl.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_external_delegate_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.h View 1 2 3 4 5 6 5 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 2 3 4 5 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 2 3 4 5 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/autocheckout_manager.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate.cc View 1 2 3 4 5 2 chunks +14 lines, -2 lines 0 comments Download
M components/autofill/browser/autofill_external_delegate_unittest.cc View 1 2 3 4 5 7 chunks +8 lines, -7 lines 0 comments Download
M components/autofill/browser/autofill_manager_delegate.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/browser/test_autofill_manager_delegate.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/browser/test_autofill_manager_delegate.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/common/autocheckout_status.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/common/autofill_messages.h View 1 2 3 4 5 2 chunks +7 lines, -2 lines 0 comments Download
M components/autofill/common/form_field_data.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/common/form_field_data.cc View 1 2 3 4 5 2 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/common/forms_seen_state.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
csharp
Adding is_rtl as a field in FormFieldData and passing it to the popup through the ...
7 years, 6 months ago (2013-06-05 18:55:30 UTC) #1
Ilya Sherman
Thanks. Just a couple of nits: https://codereview.chromium.org/15769018/diff/5002/chrome/browser/ui/autofill/autofill_popup_controller_impl.h File chrome/browser/ui/autofill/autofill_popup_controller_impl.h (right): https://codereview.chromium.org/15769018/diff/5002/chrome/browser/ui/autofill/autofill_popup_controller_impl.h#newcode72 chrome/browser/ui/autofill/autofill_popup_controller_impl.h:72: bool is_rtl); Please ...
7 years, 6 months ago (2013-06-06 09:04:03 UTC) #2
csharp
Converted most of the is_rtl to TextDirection https://codereview.chromium.org/15769018/diff/5002/chrome/browser/ui/autofill/autofill_popup_controller_impl.h File chrome/browser/ui/autofill/autofill_popup_controller_impl.h (right): https://codereview.chromium.org/15769018/diff/5002/chrome/browser/ui/autofill/autofill_popup_controller_impl.h#newcode72 chrome/browser/ui/autofill/autofill_popup_controller_impl.h:72: bool is_rtl); ...
7 years, 6 months ago (2013-06-06 14:13:53 UTC) #3
Ilya Sherman
LGTM % nits. Thanks! https://codereview.chromium.org/15769018/diff/12001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/15769018/diff/12001/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode1375 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1375: base::i18n::RIGHT_TO_LEFT : base::i18n::LEFT_TO_RIGHT); nit: Indent ...
7 years, 6 months ago (2013-06-06 21:20:46 UTC) #4
csharp
jln@ for autofill_messages.h owner's approval mkosiba@ for aw_autofill_manager_delegate.* owner's approval estade@ for gtk and views ...
7 years, 6 months ago (2013-06-07 15:22:06 UTC) #5
mkosiba (inactive)
android_webview LGTM
7 years, 6 months ago (2013-06-07 15:23:47 UTC) #6
csharp
ping jln@ and estade@
7 years, 6 months ago (2013-06-10 13:02:05 UTC) #7
Evan Stade
gtk and views lgtm
7 years, 6 months ago (2013-06-10 19:26:18 UTC) #8
jln (very slow on Chromium)
https://codereview.chromium.org/15769018/diff/46001/components/autofill/common/autofill_messages.h File components/autofill/common/autofill_messages.h (right): https://codereview.chromium.org/15769018/diff/46001/components/autofill/common/autofill_messages.h#newcode32 components/autofill/common/autofill_messages.h:32: IPC_ENUM_TRAITS(base::i18n::TextDirection) IPC_ENUM_TRAITS() is now deprecated. Please use IPC_ENUM_TRAITS_MAX_VALUE(type, maxvalue). ...
7 years, 6 months ago (2013-06-10 20:49:55 UTC) #9
csharp
darin@ for base/i18n/rtl.h owner's approval https://codereview.chromium.org/15769018/diff/46001/components/autofill/common/autofill_messages.h File components/autofill/common/autofill_messages.h (right): https://codereview.chromium.org/15769018/diff/46001/components/autofill/common/autofill_messages.h#newcode32 components/autofill/common/autofill_messages.h:32: IPC_ENUM_TRAITS(base::i18n::TextDirection) On 2013/06/10 20:49:55, ...
7 years, 6 months ago (2013-06-11 14:14:58 UTC) #10
darin (slow to review)
LGTM for base/i18n
7 years, 6 months ago (2013-06-12 00:06:12 UTC) #11
jln (very slow on Chromium)
components/autofill/common/autofill_messages.h lgtm
7 years, 6 months ago (2013-06-12 05:16:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/15769018/67001
7 years, 6 months ago (2013-06-12 14:42:09 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 15:32:33 UTC) #14
Message was sent while issue was closed. 
Change committed as 205795

Powered by Google App Engine
This is Rietveld 408576698