chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc - Issue 15769018: [Autofill] Determine Popup RTLness from page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android compile Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

index 3ff54145983011956632c6778aac9cf4c58147ee..9d385782ac58eb2f5ceb50e6ce6fdcbd96330ce9 100644

--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

@@ -139,6 +139,7 @@ void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(

void TabAutofillManagerDelegate::ShowAutofillPopup(

const gfx::RectF& element_bounds,

+ base::i18n::TextDirection text_direction,

const std::vector<string16>& values,

const std::vector<string16>& labels,

const std::vector<string16>& icons,

@@ -155,7 +156,8 @@ void TabAutofillManagerDelegate::ShowAutofillPopup(

popup_controller_,

delegate,

web_contents()->GetView()->GetNativeView(),

- element_bounds_in_screen_space);

+ element_bounds_in_screen_space,

+ text_direction);

popup_controller_->Show(values, labels, icons, identifiers);

}