Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix android compile Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
index c3c3fe1313f2547a3535769ad1e8975f01286890..7c60bd5601560171ce69a3af51a62373818784f6 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
@@ -64,7 +64,9 @@ class TestAutofillPopupController : public AutofillPopupControllerImpl {
explicit TestAutofillPopupController(
base::WeakPtr<AutofillExternalDelegate> external_delegate,
const gfx::RectF& element_bounds)
- : AutofillPopupControllerImpl(external_delegate, NULL, element_bounds) {}
+ : AutofillPopupControllerImpl(
+ external_delegate, NULL, element_bounds,
+ base::i18n::UNKNOWN_DIRECTION) {}
virtual ~TestAutofillPopupController() {}
void set_display(const gfx::Display display) {
@@ -364,21 +366,22 @@ TEST_F(AutofillPopupControllerUnitTest, GetOrCreate) {
WeakPtr<AutofillPopupControllerImpl> controller =
AutofillPopupControllerImpl::GetOrCreate(
WeakPtr<AutofillPopupControllerImpl>(), delegate.GetWeakPtr(), NULL,
- gfx::Rect());
+ gfx::Rect(), base::i18n::UNKNOWN_DIRECTION);
EXPECT_TRUE(controller.get());
controller->Hide();
controller = AutofillPopupControllerImpl::GetOrCreate(
WeakPtr<AutofillPopupControllerImpl>(), delegate.GetWeakPtr(), NULL,
- gfx::Rect());
+ gfx::Rect(), base::i18n::UNKNOWN_DIRECTION);
EXPECT_TRUE(controller.get());
WeakPtr<AutofillPopupControllerImpl> controller2 =
AutofillPopupControllerImpl::GetOrCreate(controller,
delegate.GetWeakPtr(),
NULL,
- gfx::Rect());
+ gfx::Rect(),
+ base::i18n::UNKNOWN_DIRECTION);
EXPECT_EQ(controller.get(), controller2.get());
controller->Hide();
@@ -393,7 +396,8 @@ TEST_F(AutofillPopupControllerUnitTest, GetOrCreate) {
test_controller->GetWeakPtr(),
delegate.GetWeakPtr(),
NULL,
- bounds);
+ bounds,
+ base::i18n::UNKNOWN_DIRECTION);
EXPECT_EQ(
bounds,
static_cast<AutofillPopupController*>(controller3.get())->
@@ -416,7 +420,8 @@ TEST_F(AutofillPopupControllerUnitTest, ProperlyResetController) {
popup_controller()->GetWeakPtr(),
delegate()->GetWeakPtr(),
NULL,
- gfx::Rect());
+ gfx::Rect(),
+ base::i18n::UNKNOWN_DIRECTION);
EXPECT_NE(0, controller->selected_line());
EXPECT_TRUE(controller->names().empty());
}

Powered by Google App Engine
This is Rietveld 408576698