chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm - Issue 15769018: [Autofill] Determine Popup RTLness from page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

Issue 15769018: [Autofill] Determine Popup RTLness from page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android compile Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

index 351cefed0bed7d9e1ae09ffeb540fe77b6dd6573..c88a270e8cd9d52fd31060c6762cec5496c70321 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm

@@ -4,7 +4,6 @@

#import "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"

-#include "base/i18n/rtl.h"

#include "base/logging.h"

#include "base/strings/sys_string_conversions.h"

#include "chrome/browser/ui/autofill/autofill_popup_controller.h"

@@ -196,7 +195,7 @@ NSColor* SubtextColor() {

[NSBezierPath fillRect:bounds];

}

- BOOL isRTL = base::i18n::IsRTL();

+ BOOL isRTL = controller_->IsRTL();

NSDictionary* nameAttributes =

[NSDictionary dictionaryWithObjectsAndKeys: