Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 15422005: Remove unused includes from core/html .cpp files (Closed)

Created:
7 years, 7 months ago by Timothy Loh
Modified:
7 years, 7 months ago
Reviewers:
pdr., Timothy Loh
CC:
blink-reviews, kenneth.christiansen, gavinp+prerender_chromium.org, eae+blinkwatch, feature-media-reviews_chromium.org, Rik, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove unused includes from core/html .cpp files Splitting up codereview.chromium.org/15447002 into smaller patches. BUG=242216 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150957

Patch Set 1 #

Total comments: 4

Patch Set 2 : add back HTMLNames.h includes #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -284 lines) Patch
M Source/core/html/BaseButtonInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/BaseDateAndTimeInputType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/ClassList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/DOMURL.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/DateInputType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/FileInputType.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLBRElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLDataListElement.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLDivElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFontElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLHRElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLHeadElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLImageLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLIElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 2 chunks +0 lines, -16 lines 0 comments Download
M Source/core/html/HTMLMetaElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOListElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLOutputElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLParagraphElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/html/HTMLPreElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableCaptionElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTemplateElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLUListElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/InputType.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/LabelableElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/MediaDocument.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/MediaFragmentURIParser.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/MonthInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/PluginDocument.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/RadioInputType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/RangeInputType.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/TelephoneInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/TextFieldInputType.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/URLInputType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/ValidationMessage.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasGradient.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLBuffer.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLContextGroup.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLDebugRendererInfo.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLFramebuffer.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLObject.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/html/canvas/WebGLProgram.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderbuffer.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLShader.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLTexture.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/ime/InputMethodContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/CompactHTMLToken.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLElementStack.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLFormattingElementList.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLViewSourceParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/parser/TextDocumentParser.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/HTMLContentElement.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MeterShadowElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/track/LoadableTextTrack.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCueGeneric.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/WebVTTElement.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Timothy Loh
7 years, 7 months ago (2013-05-22 00:26:20 UTC) #1
pdr.
LGTM with nits. https://codereview.chromium.org/15422005/diff/1/Source/core/html/HTMLDListElement.cpp File Source/core/html/HTMLDListElement.cpp (left): https://codereview.chromium.org/15422005/diff/1/Source/core/html/HTMLDListElement.cpp#oldcode26 Source/core/html/HTMLDListElement.cpp:26: #include "HTMLNames.h" iwyu might have gotten ...
7 years, 7 months ago (2013-05-22 04:07:41 UTC) #2
Timothy Loh
On 2013/05/22 04:07:41, pdr wrote:https://codereview.chromium.org/15422005/diff/1/Source/core/html/HTMLDListElement.cpp#oldcode26 > Source/core/html/HTMLDListElement.cpp:26: #include "HTMLNames.h" > iwyu might have gotten a ...
7 years, 7 months ago (2013-05-22 04:29:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15422005/5001
7 years, 7 months ago (2013-05-22 04:30:11 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6011
7 years, 7 months ago (2013-05-22 08:12:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15422005/5001
7 years, 7 months ago (2013-05-22 08:24:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=6049
7 years, 7 months ago (2013-05-22 12:23:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15422005/5001
7 years, 7 months ago (2013-05-23 02:05:33 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLFrameSetElement.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-23 02:06:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/15422005/27001
7 years, 7 months ago (2013-05-23 03:24:45 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 04:33:41 UTC) #11
Message was sent while issue was closed.
Change committed as 150957

Powered by Google App Engine
This is Rietveld 408576698