chrome/browser/signin/oauth2_token_service_unittest.cc - Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/oauth2_token_service_unittest.cc

Issue 14696007: Warn on missing OVERRIDE/virtual everywhere, not just in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: new regressions, attempt 3 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/oauth2_token_service_unittest.cc

diff --git a/chrome/browser/signin/oauth2_token_service_unittest.cc b/chrome/browser/signin/oauth2_token_service_unittest.cc

index 8f96f131a5405e80b6b7459ce7037b0fca7fd76e..4acffb9af52f44a56b6baab52c7902eb0e6ff130 100644

--- a/chrome/browser/signin/oauth2_token_service_unittest.cc

+++ b/chrome/browser/signin/oauth2_token_service_unittest.cc

@@ -54,9 +54,7 @@ class TestOAuth2TokenService : public OAuth2TokenService {

}

protected:

- std::string GetRefreshToken() OVERRIDE {

- return refresh_token_;

- }

+ virtual std::string GetRefreshToken() OVERRIDE { return refresh_token_; }

private:

std::string refresh_token_;