Update the R= line with the actual list of reviewers that approved the CL.

Update the R= line with the actual list of reviewers that approved the CL.

This makes the commit logs much more useful for a build sheriff. Not only he
sees who committed the CL but see who approved it directly at the log. This
should help build sheriffs when they fail to contact the author and want to
fallback on the reviewer for quick questions.

R=dpranke@chromium.org
BUG=76730
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=196786

[M-A Ruel, 2013-04-08 21:45:43]

This CL depends on https://codereview.chromium.org/13800018.
The corresponding CQ CL is https://codereview.chromium.org/13483026.

[Dirk Pranke, 2013-04-09 00:15:51]

https://codereview.chromium.org/13800021/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/13800021/diff/1/git_cl.py#newcode650
git_cl.py:650: def GetActualReviewers(self, issue):
should this be GetRealReviewers to match?

https://codereview.chromium.org/13800021/diff/1/git_cl.py#newcode883
git_cl.py:883: """Retrieves the reviewers that approved a cL from the issue
properties with
nit: "CL", not "cL".

I wonder if this should be "get_approving_reviewers" or something instead of the
"real" reviewers, since "real" is potentially confusing.

[M-A Ruel, 2013-04-11 01:11:28]

Updated

https://codereview.chromium.org/13800021/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/13800021/diff/1/git_cl.py#newcode650
git_cl.py:650: def GetActualReviewers(self, issue):
On 2013/04/09 00:15:51, Dirk Pranke wrote:
> should this be GetRealReviewers to match?

GetApprovingReviewers()

https://codereview.chromium.org/13800021/diff/1/git_cl.py#newcode883
git_cl.py:883: """Retrieves the reviewers that approved a cL from the issue
properties with
On 2013/04/09 00:15:51, Dirk Pranke wrote:
> nit: "CL", not "cL".
> 
> I wonder if this should be "get_approving_reviewers" or something instead of
the
> "real" reviewers, since "real" is potentially confusing.

Done.

[Dirk Pranke, 2013-04-11 01:13:39]

lgtm

[commit-bot: I haz the power, 2013-04-26 18:25:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/13800021/19001

[commit-bot: I haz the power, 2013-04-26 18:26:56]

Presubmit check for 13800021-19001 failed and returned exit status 1.

INFO:root:Found 4 file(s).
INFO:PRESUBMIT:Running pylint on 60 files
Running presubmit commit checks ...
Running /b/commit-queue/workdir/tools/depot_tools/PRESUBMIT.py
Running tests/gclient_utils_test.py
Running tests/watchlists_unittest.py
Running tests/checkout_test.py
Running tests/scm_unittest.py
Running tests/gcl_unittest.py
Running tests/patch_test.py
Running tests/fix_encoding_test.py
Running tests/presubmit_unittest.py
Running tests/trychange_unittest.py
Running tests/rietveld_test.py
Running tests/owners_unittest.py
Running tests/breakpad_unittest.py
Running tests/gclient_test.py
Running tests/gclient_smoketest.py
Running tests/subprocess2_test.py
Running tests/git_cl_test.py
Running tests/gclient_scm_test.py
INFO:root:/usr/bin/python /b/google_appengine/dev_appserver.py . --port 8080
--storage /tmp/rietveld_testKMszOn --clear_search_indexes
--skip_sdk_update_check
Setting up test upstream git repo...
Setting up test git repo...
TESTING: uploading to bogus server
 test | 1 +
 1 file changed, 1 insertion(+)
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit upload checks ...

Presubmit checks passed.
Upload server: http://bogus.example.com:80 (change with -s/--server)
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies

Got exception while uploading -- saving description to
/home/chrome-bot/.git_cl_description_backup

TESTING: description was backed up
PASS
Setting up test upstream git repo...
Setting up test git repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1363 --:--:-- --:--:-- --:--:--  1400
TESTING: Base URL contains branch name
TESTING: git-cl push ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5629499534213120'
Closing issue (you may be prompted for your codereview password)...
TESTING: committed code has proper description
TESTING: issue no longer has a branch
TESTING: upstream repo has our commit
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
The --set-upstream flag is deprecated and will be removed. Consider using
--track or --set-upstream-to
Branch feature_branch set up to track local ref refs/remotes/trunk.
TESTING: Guessing upstream branch for refs/remotes/trunk
The --set-upstream flag is deprecated and will be removed. Consider using
--track or --set-upstream-to
Branch feature_branch set up to track local ref refs/remotes/some_branch.
TESTING: Guessing upstream branch for refs/remotes/some_branch
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'test\n\nBUG=\n\nReview URL:
http://localhost:8080/5910974510923776'
Closing issue (you may be prompted for your codereview password)...
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

Switched to branch 'master'
Deleted branch abandoned (was cb84eed).
TESTING: git-cl status dropped abandoned branch
PASS
Setting up test SVN repo...
Setting up test remote git-svn-submodule repo...
Switched to branch 'master'
TESTING: dcommitted code
Switched to branch 'git-cl-cherry-pick'
Using 50% similarity for rename/copy detection. Override with --similarity.
Description: 'dcommit'
TESTING: svn got new revision
TESTING: svn diff is correct
TESTING: git svn fetch gets new svn revision
PASS
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload hook fails
Command "git config rietveld.server" failed.
Could not find settings file. You must configure your review setup by running
"git cl config".
TESTING: git-cl dcommit hook fails
Command "git config rietveld.server" failed.
Could not find settings file. You must configure your review setup by running
"git cl config".
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
Using 50% similarity for rename/copy detection. Override with --similarity.
Description: 'dcommit'
TESTING: post-cl-dcommit hook executed
PASS
Setting up test upstream git repo...
Setting up test git repo...
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: description shouldn't contain unrelated commits
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
TESTING: git cl patch 5981343255101440
PASS
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)

WARNING: Use -t or --title to set the title of the patchset.
In the near future, -m or --message will send a message instead.
See http://goo.gl/JGg0Z for details.

TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1563 --:--:-- --:--:-- --:--:--  1604
TESTING: git-cl dcommits ok
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /home/chrome-bot/.codereview_upload_cookies
Running presubmit commit checks ...

Presubmit checks passed.
Description: 'foo-quux\n\nReview URL: http://localhost:8080/5840605766746112'
Closing issue (you may be prompted for your codereview password)...
TESTING: dcommitted code has proper description
TESTING: issue no longer has a branch
TESTING: upstream svn has our commit
PASS
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/checkout_test.py failed
testAll (__main__.RawCheckout) ... ok
testException (__main__.RawCheckout) ... ok
testMove (__main__.RawCheckout) ... ok
testPrepare (__main__.RawCheckout) ... ok
testProcess (__main__.RawCheckout) ... ok
testAll (__main__.ReadOnlyCheckout) ... ok
testException (__main__.ReadOnlyCheckout) ... ok
testMove (__main__.ReadOnlyCheckout) ... ok
testPrepare (__main__.ReadOnlyCheckout) ... ok
testProcess (__main__.ReadOnlyCheckout) ... ok
testAll (__main__.SvnCheckout) ... ok
testAutoProps (__main__.SvnCheckout) ... ok
testException (__main__.SvnCheckout) ... ok
testMove (__main__.SvnCheckout) ... FAIL
testPrepare (__main__.SvnCheckout) ... ok
testProcess (__main__.SvnCheckout) ... ok
testSvnProps (__main__.SvnCheckout) ... ok
testWithRevPropsSupport (__main__.SvnCheckout) ... ok
testWithRevPropsSupportNotCommitBot (__main__.SvnCheckout) ... ok

======================================================================
FAIL: testMove (__main__.SvnCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/checkout_test.py", line 407, in testMove
    self.assertEquals(expected, out)
AssertionError: 'A  +    chromeos/views/webui_menu_widget.h\nD      
chromeos/views/DOMui_menu_widget.h\n' != 'D      
chromeos/views/DOMui_menu_widget.h\nA  +   
chromeos/views/webui_menu_widget.h\n'

----------------------------------------------------------------------
Ran 19 tests in 9.189s

FAILED (failures=1)


Presubmit checks took 87.4s to calculate.

[commit-bot: I haz the power, 2013-04-26 18:33:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/13800021/19001

[commit-bot: I haz the power, 2013-04-26 18:34:44]

Change committed as 196786