Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: gcl.py

Issue 13800021: Update the R= line with the actual list of reviewers that approved the CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@3_gcl_refactor
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 6691a601ca03ebb3ee940b3228ec5b27fd3efa66..11d58e07ba5d7d8a3efe05e5ea5b83f3a715f9b4 100755
--- a/gcl.py
+++ b/gcl.py
@@ -299,6 +299,9 @@ class ChangeInfo(object):
def get_reviewers(self):
return self._desc.get_reviewers()
+ def update_reviewers(self, reviewers):
+ self._desc.update_reviewers(reviewers)
+
def NeedsUpload(self):
return self.needs_upload
@@ -383,6 +386,11 @@ class ChangeInfo(object):
self._desc = git_cl.ChangeDescription(
self.SendToRietveld('/%d/description' % self.issue))
+ def GetApprovingReviewers(self):
+ """Returns the issue reviewers list from Rietveld."""
+ return git_cl.get_approving_reviewers(
+ self.rietveld.get_issue_properties(self.issue, False))
+
def AddComment(self, comment):
"""Adds a comment for an issue on Rietveld.
As a side effect, this will email everyone associated with the issue."""
@@ -995,6 +1003,8 @@ def CMDcommit(change_info, args):
# Get the latest description from Rietveld.
change_info.UpdateDescriptionFromIssue()
+ change_info.update_reviewers(change_info.GetApprovingReviewers())
+
commit_desc = git_cl.ChangeDescription(change_info.description)
if change_info.issue:
server = change_info.rietveld
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698