Update the R= line with the actual list of reviewers that approved the CL.

tests/git_cl_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for git_cl.py."""
 
 import os
 import StringIO
 import stat
@@ skipping 80 matching lines @@
   def tearDown(self):
     if not self.has_failed():
       self.assertEquals([], self.calls)
     super(TestGitCl, self).tearDown()
 
   def _mocked_call(self, *args, **kwargs):
     self.assertTrue(
         self.calls,
         '@%d  Expected: <Missing>   Actual: %r' % (self._calls_done, args))
     expected_args, result = self.calls.pop(0)
-    self.assertEquals(
-        expected_args,
-        args,
-        '@%d  Expected: %r   Actual: %r' % (
-          self._calls_done, expected_args, args))
+    # Also logs otherwise it could get caught in a try/finally and be hard to
+    # diagnose.
+    if expected_args != args:
+      msg = '@%d  Expected: %r   Actual: %r' % (
+          self._calls_done, expected_args, args)
+      git_cl.logging.error(msg)
+      self.fail(msg)
     self._calls_done += 1
     return result
 
   @classmethod
   def _upload_calls(cls, similarity, find_copies):
     return (cls._git_base_calls(similarity, find_copies) +
             cls._git_upload_calls())
 
   @classmethod
   def _git_base_calls(cls, similarity, find_copies):
@@ skipping 161 matching lines @@
       ((['git', 'show-ref', '--quiet', '--verify',
          'refs/heads/git-cl-commit'],),
        (('', None), 0)),
       ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
       ((['git', 'show-ref', '--quiet', '--verify',
          'refs/heads/git-cl-cherry-pick'],), ''),
       ((['git', 'rev-parse', '--show-cdup'],), '\n'),
       ((['git', 'checkout', '-q', '-b', 'git-cl-commit'],), ''),
       ((['git', 'reset', '--soft', 'fake_ancestor_sha'],), ''),
       ((['git', 'commit', '-m',
-         'Issue: 12345\n\n'
+         'Issue: 12345\n\nR=john@chromium.org\n\n'
          'Review URL: https://codereview.example.com/12345'],),
        ''),
       ((['git', 'svn', 'dcommit', '-C50', '--no-rebase', '--rmdir'],),
        (('', None), 0)),
       ((['git', 'checkout', '-q', 'working'],), ''),
       ((['git', 'branch', '-D', 'git-cl-commit'],), ''),
   ]
 
   @staticmethod
   def _cmd_line(description, args, similarity, find_copies):
@@ skipping 330 matching lines @@
       obj = git_cl.ChangeDescription(orig)
       obj.update_reviewers(reviewers)
       actual.append(obj.description)
     self.assertEqual(expected, actual)
 
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(
       level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
   unittest.main()