Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tests/gcl_unittest.py

Issue 13800021: Update the R= line with the actual list of reviewers that approved the CL. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@3_gcl_refactor
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gcl_unittest.py
diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py
index 1030c5b7578379f59ef8a0dbc393f16b6ec71905..81823ab73857b45af195d7a267a6d63cddd30f6c 100755
--- a/tests/gcl_unittest.py
+++ b/tests/gcl_unittest.py
@@ -192,14 +192,15 @@ class ChangeInfoUnittest(GclTestsBase):
self.mox.ReplayAll()
members = [
'AddComment', 'CloseIssue', 'Delete', 'Exists', 'GetFiles',
- 'GetFileNames', 'GetLocalRoot', 'GetIssueDescription', 'Load',
+ 'GetApprovingReviewers', 'GetFileNames', 'GetIssueDescription',
+ 'GetLocalRoot', 'Load',
'MissingTests', 'NeedsUpload', 'PrimeLint', 'RpcServer', 'Save',
'SendToRietveld',
'SEPARATOR',
'UpdateDescriptionFromIssue', 'UpdateRietveldDescription',
'append_footer',
'description', 'force_description', 'get_reviewers', 'issue', 'name',
- 'needs_upload', 'patch', 'patchset', 'rietveld',
+ 'needs_upload', 'patch', 'patchset', 'rietveld', 'update_reviewers',
]
# If this test fails, you should add the relevant test.
self.compareMembers(
@@ -576,6 +577,8 @@ class CMDCommitUnittest(GclTestsBase):
self.mockCommit(
change_info, 'deescription\n\nReview URL: https://my_server/1', '')
change_info.UpdateDescriptionFromIssue()
+ change_info.GetApprovingReviewers().AndReturn(['a@c'])
+ change_info.update_reviewers(['a@c'])
self.mox.ReplayAll()
retval = gcl.CMDcommit(['naame'])
@@ -594,6 +597,8 @@ class CMDCommitUnittest(GclTestsBase):
'deescription\n\nReview URL: https://my_server/1',
'\nCommitted revision 12345')
change_info.UpdateDescriptionFromIssue()
+ change_info.GetApprovingReviewers().AndReturn(['a@c'])
+ change_info.update_reviewers(['a@c'])
change_info.append_footer('Committed: http://view/12345')
self.mox.ReplayAll()
« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698