Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 1374053002: Remove AboutToNavigateRenderFrame, issue custom notification for DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index c4fc6bfab09f1bec85254aee6bb3a71660043333..c2fcffbe0f2efb50491184386b27a6aa11d21753 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -206,16 +206,6 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// ---------------------------------------------------------------------------
- // This method is invoked after the WebContents decides which RenderFrameHost
- // to use for the next browser-initiated navigation, but before the navigation
- // starts. It is not called for most renderer-initiated navigations, and it
- // does not guarantee that the navigation will commit (e.g., 204s, downloads).
- //
- // DEPRECATED. This method is difficult to use correctly and should be
- // removed. TODO(creis): Remove in http://crbug.com/424641.
- virtual void AboutToNavigateRenderFrame(RenderFrameHost* old_host,
- RenderFrameHost* new_host) {}
-
// This method is invoked after the browser process starts a navigation to a
// pending NavigationEntry. It is not called for renderer-initiated
// navigations unless they are sent to the browser process via OpenURL. It may

Powered by Google App Engine
This is Rietveld 408576698