Remove AboutToNavigateRenderFrame, issue custom notification for DevTools.

Remove AboutToNavigateRenderFrame, issue custom notification for DevTools.

DevTools gets a notification right before FrameMsg_Navigate is sent. This
ensures that we can pause in onbeforeunload, pretend that navigation
did not happen yet and debug the page.

As DevTools was the last client of AboutToNavigateRenderFrame, the
notification itself is removed.

BUG=131371
TBR=pavely@chromium.org (for test)

Committed: https://crrev.com/3723dfcf3d1ba40102029e4a1f989539ab5c9022
Cr-Commit-Position: refs/heads/master@{#352389}

[dgozman, 2015-09-28 22:16:31]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 22:18:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374053002/1

[dgozman, 2015-09-28 22:20:26]

dgozman@chromium.org changed reviewers:
+ creis@chromium.org, yurys@chromium.org

[dgozman, 2015-09-28 22:20:26]

Hi,

Could you please take a look? This is a successor of
https://codereview.chromium.org/1358153002/.

Turned out we already disable the hang monitor while debugging, so that doesn't
disturb beforeunload case. See the test here:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/de....

Thanks,
Dmitry

[commit-bot: I haz the power, 2015-09-28 22:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 22:59:49]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yurys, 2015-09-28 23:37:30]

lgtm

https://codereview.chromium.org/1374053002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/1374053002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_impl.cc:1710: Send(new
FrameMsg_Navigate(routing_id_, common_params, start_params,
Let's extract this into a method to avoid FrameMsg_Navigate being added without
a call to OnBeforeNavigation in the future.

[Charlie Reis, 2015-09-28 23:44:30]

Yes, this is much nicer.  LGTM once the test passes the bots.

[dgozman, 2015-09-29 18:26:58]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-29 18:29:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374053002/1

[commit-bot: I haz the power, 2015-09-29 19:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 19:17:46]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[dgozman, 2015-10-01 01:01:53]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 01:04:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374053002/20001

[commit-bot: I haz the power, 2015-10-01 01:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 01:43:10]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[dgozman, 2015-10-01 20:15:26]

https://chromiumcodereview.appspot.com/1374053002/diff/1/content/browser/fram...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://chromiumcodereview.appspot.com/1374053002/diff/1/content/browser/fram...
content/browser/frame_host/render_frame_host_impl.cc:1710: Send(new
FrameMsg_Navigate(routing_id_, common_params, start_params,
On 2015/09/28 23:37:30, yurys wrote:
> Let's extract this into a method to avoid FrameMsg_Navigate being added
without
> a call to OnBeforeNavigation in the future.

Done.

[dgozman, 2015-10-01 20:16:20]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 20:16:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374053002/40001

[commit-bot: I haz the power, 2015-10-01 20:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 20:22:57]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dgozman, 2015-10-05 18:12:32]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-10-05 18:12:33]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
yurys@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1374053002/#ps40001
(title: "rebased, win test fix")

[commit-bot: I haz the power, 2015-10-05 18:16:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374053002/40001

[commit-bot: I haz the power, 2015-10-05 19:40:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-05 19:40:59]

Patchset 3 (id:??) landed as
https://crrev.com/3723dfcf3d1ba40102029e4a1f989539ab5c9022
Cr-Commit-Position: refs/heads/master@{#352389}